Page MenuHomePhabricator

[Cashtab] Airdrop Option - ignore own address
ClosedPublic

Authored by emack on Mar 23 2022, 12:10.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC0142e0e83a99: [Cashtab] Airdrop Option - ignore own address
Summary

Option to exclude the airdrop sender's address from the list of recipients.

Test Plan

npm start
ensure normal airdrop calculation is correct
tick the Ignore my own address option then ensure airdrop calculation excludes the active address, including the distribution ratio of XEC

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested review of this revision.Mar 23 2022, 12:10
bytesofman added inline comments.
web/cashtab/src/components/Airdrop/Airdrop.js
143 ↗(On Diff #32984)

Is this step only required for the case where ignoreOwnAddress is true?

If so, include this calc inside if (ignoreOwnAddress)

384 ↗(On Diff #32984)

For a boolean setting, use a switch instead of a checkbox (I think better UX for mobile; this is what Cashtab does everywhere else).

This revision now requires changes to proceed.Mar 30 2022, 16:48
emack marked 2 inline comments as done.
  • Moved Path1899 etoken address reference into ignoreOwnAddress block
  • Switched from checkbox to switch toggle

Adjusted switch/label positioning

This revision is now accepted and ready to land.Mar 31 2022, 16:23
This revision was automatically updated to reflect the committed changes.