Page MenuHomePhabricator

[Cashtab-v2] fix secondary button disabled cursor
AbandonedPublic

Authored by kieran709 on Mar 28 2022, 16:54.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Related to task T2359. In a previous revision, the SecondaryButton styled component was changed to show the disabled symbol on hover, however since this button is used in different contexts throughout the app, this revision sets the desired cursor in Send.js, but not elsewhere in the app where the button requires a pointer cursor.

Test Plan

cd web/cashtab-v2 && npm start
in a private browser, hover over the import wallet button on the home screen
the cursor should be a pointer
in a non-private browser
navigate to the send screen
add invalid eCash address or invalid XEC amount
over over the send button
observe the disabled symbol on the send button.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-disabled-cursor-on-import-button
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18651
Build 37093: Build Diff
Build 37092: arc lint + arc unit

Event Timeline

We should have different components for PrimaryButton, SecondaryButton, and DisabledButton -- a series of hacky fixes is only going to cause more confusion in the future.

This revision now requires changes to proceed.Mar 28 2022, 17:03

responded to review feedback & updated snapshots