Paths

Table of Contentst

Differential D11284

[Cashtab] Remove titles from send.svg & cog.svg
ClosedPublic
Actions

Authored by kieran709 on Mar 30 2022, 16:54.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC1af8308964d4: [Cashtab] Remove titles from send.svg & cog.svg

Summary

Related to task T2356. The settings cog and send icon had tooltip popups of their titles, despite the rest of the icons not having tooltips on hover. Removed the titles from send.svg and cog.svg to create uniformity across all icons.

Test Plan

cd web/cashtab && npm start
hover over the Send icon in the navbar, observe the lack of tooltip
hover over the Cog icon in the navbar, observe the lack of tooltip.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kieran709 created this revision.Mar 30 2022, 16:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2022, 16:54

kieran709 requested review of this revision.Mar 30 2022, 16:54

Harbormaster completed remote builds in B18682: Diff 33000.Mar 30 2022, 16:57

Also remove the <title></title> brackets from each svg

This revision now requires changes to proceed.Mar 30 2022, 17:31

responding to review feedback

Harbormaster completed remote builds in B18687: Diff 33005.Mar 30 2022, 17:48

bytesofman accepted this revision.Mar 30 2022, 17:51

This revision is now accepted and ready to land.Mar 30 2022, 17:51

Closed by commit rABC1af8308964d4: [Cashtab] Remove titles from send.svg & cog.svg (authored by kieran709). · Explain WhyMar 30 2022, 18:38

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC1af8308964d4: [Cashtab] Remove titles from send.svg & cog.svg.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

assets/

2 lines

2 lines

Diff 33007

web/cashtab/src/assets/cog.svg

Loading...

web/cashtab/src/assets/send.svg

Loading...