As per T2368, adding a Verify Message feature to complement the existing Sign Message function.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCa6ccd842b996: [Cashtab] Verify Message feature
- Navigate to Send component
- Use the Sign Message feature to sign a message using the activate wallet, noting the address, message and signature
- Enter the message, address and signature into the Verify Message feature and ensure successful verification
- enter an invalid cash address or valid etoken address and ensure error validation is triggered
- enter a signature that is not 88 characters and ensure error validation is triggered
- ensure the Verify Message button is only active when the Message is not empty, Address is a valid eCash address and the Signature is exactly 88 characters. Ensure it is inactive when one of the three fields is invalid.
- test across chrome/brave/firefox browsers and iOS/Android devices
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/cashtab/src/hooks/useBCH.js | ||
|---|---|---|
| 1324 ↗ | (On Diff #33019) | I know we have this function split out here for signing, but I think similar situation as earlier discussed. This function isn't really doing anything more than the BCH.BitcoinCash.verifyMessage function; so we should just use that function instead. As a rule of thumb, if we can't add unit tests for a low-level function in Cashtab, then we shouldn't add the function. |
Comment Actions
Going forward, we'll
- add a screen to contain all of the signature logic
- get rid of the signPk function in useBCH.js
- Consider getting rid of the confirmation modals
But this is effective as is and important to have given the signature discrepancies between electrum and cashtab.