Page MenuHomePhabricator
Differential D11308

[refactor] txmempool: split epoch logic into class
ClosedPublic
Actions

Authored by PiRK on Apr 5 2022, 12:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd4e83e3031ce: [refactor] txmempool: split epoch logic into class
Summary

This is a backport of core#18017

Test Plan

With clang and debug:
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Apr 5 2022, 12:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2022, 12:37
PiRK requested review of this revision.Apr 5 2022, 12:37
teamcity edited the summary of this revision. (Show Details)Apr 5 2022, 12:37
Harbormaster completed remote builds in B18734: Diff 33072.Apr 5 2022, 12:55
Fabien edited the summary of this revision. (Show Details)Apr 5 2022, 14:53
Fabien edited the test plan for this revision. (Show Details)
Fabien requested changes to this revision.Apr 5 2022, 15:01
Fabien added a subscriber: Fabien.

Same here, you need clang

This revision now requires changes to proceed.Apr 5 2022, 15:01
PiRK edited the test plan for this revision. (Show Details)Apr 5 2022, 15:57
PiRK updated this revision to Diff 33080.Apr 5 2022, 16:01

move comment to own line and edit test plan

Harbormaster completed remote builds in B18737: Diff 33080.Apr 5 2022, 16:18
Fabien accepted this revision.Apr 5 2022, 16:39
This revision is now accepted and ready to land.Apr 5 2022, 16:39
PiRK updated this revision to Diff 33099.Apr 6 2022, 07:02

Something fishy is going on with arcanist not associating the commit and revision, so rebase just to be sure.

Harbormaster completed remote builds in B18746: Diff 33099.Apr 6 2022, 07:31
Closed by commit rABCd4e83e3031ce: [refactor] txmempool: split epoch logic into class (authored by Anthony Towns <aj@erisian.com.au>, committed by PiRK). · Explain WhyApr 6 2022, 13:27
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd4e83e3031ce: [refactor] txmempool: split epoch logic into class.
Pink-e-Cash added a subscriber: Pink-e-Cash.Dec 8 2022, 21:21

Revision Contents
Changeset List

PathSize
src/
56 lines
20 lines
util/
89 lines

Diff 33105

View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/util/epochguard.h

Loading...