Page MenuHomePhabricator
Differential D11314

[avalanche] Handle tx inv polls with a stub handler.
ClosedPublic
Actions

Authored by tyler-smith on Apr 6 2022, 06:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4549974dd90c: [avalanche] Handle tx inv polls with a stub handler.
Summary

Changes the AVAPOLL message handler to recognize MSG_TX invs and respond to them with votes based on a helper function in the same pattern as we do for block and proof polls.

The actual implementation of the helper function is left for a follow-on revision.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tyler-smith created this revision.Apr 6 2022, 06:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 6 2022, 06:48
tyler-smith requested review of this revision.Apr 6 2022, 06:48
Harbormaster completed remote builds in B18745: Diff 33096.Apr 6 2022, 06:56
teamcity added a comment.Apr 6 2022, 06:56
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T06:55:12.229000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_065302/abc_p2p_avalanche_transaction_voting_204
2022-04-06T06:55:12.660000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 51, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2022-04-06T06:55:12.711000Z TestFramework (INFO): Stopping nodes
2022-04-06T06:55:12.864000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_065302/abc_p2p_avalanche_transaction_voting_204
2022-04-06T06:55:12.864000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_065302/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T06:55:12.864000Z TestFramework (ERROR): 
2022-04-06T06:55:12.865000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_065302/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T06:55:12.865000Z TestFramework (ERROR): 
2022-04-06T06:55:12.865000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T06:55:12.866000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T06:55:12.866000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py

teamcity added a comment.Apr 6 2022, 07:00
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T06:58:40.256000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_065303/abc_p2p_avalanche_transaction_voting_204
2022-04-06T06:58:40.991000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 51, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Wallet file verification failed. Failed to create database path '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_065303/abc_p2p_avalanche_transaction_voting_204/node0/regtest'. Database already exists. (-4)
2022-04-06T06:58:41.042000Z TestFramework (INFO): Stopping nodes
2022-04-06T06:58:41.194000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_065303/abc_p2p_avalanche_transaction_voting_204
2022-04-06T06:58:41.194000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_065303/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T06:58:41.194000Z TestFramework (ERROR): 
2022-04-06T06:58:41.194000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_065303/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T06:58:41.194000Z TestFramework (ERROR): 
2022-04-06T06:58:41.194000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T06:58:41.194000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T06:58:41.194000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py

teamcity added a comment.Apr 6 2022, 07:04
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T06:58:38.445000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065427/abc_p2p_avalanche_transaction_voting_204
2022-04-06T06:58:38.915000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 51, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Wallet file verification failed. Failed to create database path '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065427/abc_p2p_avalanche_transaction_voting_204/node0/regtest'. Database already exists. (-4)
2022-04-06T06:58:38.969000Z TestFramework (INFO): Stopping nodes
2022-04-06T06:58:39.173000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065427/abc_p2p_avalanche_transaction_voting_204
2022-04-06T06:58:39.173000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065427/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T06:58:39.174000Z TestFramework (ERROR): 
2022-04-06T06:58:39.174000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065427/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T06:58:39.174000Z TestFramework (ERROR): 
2022-04-06T06:58:39.174000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T06:58:39.175000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T06:58:39.175000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T07:02:34.854000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065839/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:02:35.356000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 51, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Wallet file verification failed. Failed to create database path '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065839/abc_p2p_avalanche_transaction_voting_204/node0/regtest'. Database already exists. (-4)
2022-04-06T07:02:35.406000Z TestFramework (INFO): Stopping nodes
2022-04-06T07:02:35.558000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065839/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:02:35.558000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065839/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T07:02:35.558000Z TestFramework (ERROR): 
2022-04-06T07:02:35.558000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_065839/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T07:02:35.558000Z TestFramework (ERROR): 
2022-04-06T07:02:35.558000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T07:02:35.558000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T07:02:35.558000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py

tyler-smith updated this revision to Diff 33100.Apr 6 2022, 07:22

Use a clean chain in tests.

Harbormaster completed remote builds in B18747: Diff 33100.Apr 6 2022, 07:36
teamcity added a comment.Apr 6 2022, 07:36
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T07:35:55.011000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_073332/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:35:55.423000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 52, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2022-04-06T07:35:55.474000Z TestFramework (INFO): Stopping nodes
2022-04-06T07:35:55.727000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_073332/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:35:55.727000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_073332/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T07:35:55.727000Z TestFramework (ERROR): 
2022-04-06T07:35:55.728000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220406_073332/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T07:35:55.728000Z TestFramework (ERROR): 
2022-04-06T07:35:55.728000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T07:35:55.728000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T07:35:55.729000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py

teamcity added a comment.Apr 6 2022, 07:38
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T07:38:06.271000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_073214/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:38:06.978000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 52, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Wallet file verification failed. Failed to create database path '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_073214/abc_p2p_avalanche_transaction_voting_204/node0/regtest/wallets'. Database already exists. (-4)
2022-04-06T07:38:07.028000Z TestFramework (INFO): Stopping nodes
2022-04-06T07:38:07.180000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_073214/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:38:07.180000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_073214/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T07:38:07.180000Z TestFramework (ERROR): 
2022-04-06T07:38:07.180000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220406_073214/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T07:38:07.180000Z TestFramework (ERROR): 
2022-04-06T07:38:07.180000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T07:38:07.180000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T07:38:07.180000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py

teamcity added a comment.Apr 6 2022, 07:43
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T07:37:47.661000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073341/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:37:48.406000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 52, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Wallet file verification failed. Failed to create database path '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073341/abc_p2p_avalanche_transaction_voting_204/node0/regtest/wallets'. Database already exists. (-4)
2022-04-06T07:37:48.457000Z TestFramework (INFO): Stopping nodes
2022-04-06T07:37:48.711000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073341/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:37:48.712000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073341/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T07:37:48.712000Z TestFramework (ERROR): 
2022-04-06T07:37:48.712000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073341/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T07:37:48.713000Z TestFramework (ERROR): 
2022-04-06T07:37:48.713000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T07:37:48.713000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T07:37:48.713000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py ======

------- Stdout: -------
2022-04-06T07:41:32.960000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073749/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:41:33.431000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_transaction_voting.py", line 52, in run_test
    node.createwallet(self.default_wallet_name)
  File "/work/test/functional/test_framework/test_node.py", line 891, in createwallet
    wallet_name, disable_private_keys, blank, passphrase, avoid_reuse, descriptors, load_on_startup)
  File "/work/test/functional/test_framework/coverage.py", line 47, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/work/test/functional/test_framework/authproxy.py", line 163, in __call__
    raise JSONRPCException(response['error'], status)
test_framework.authproxy.JSONRPCException: Wallet file verification failed. Failed to create database path '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073749/abc_p2p_avalanche_transaction_voting_204/node0/regtest/wallets'. Database already exists. (-4)
2022-04-06T07:41:33.482000Z TestFramework (INFO): Stopping nodes
2022-04-06T07:41:33.633000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073749/abc_p2p_avalanche_transaction_voting_204
2022-04-06T07:41:33.633000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073749/abc_p2p_avalanche_transaction_voting_204/test_framework.log
2022-04-06T07:41:33.633000Z TestFramework (ERROR): 
2022-04-06T07:41:33.633000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220406_073749/abc_p2p_avalanche_transaction_voting_204' to consolidate all logs
2022-04-06T07:41:33.633000Z TestFramework (ERROR): 
2022-04-06T07:41:33.633000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-06T07:41:33.634000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-06T07:41:33.634000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_transaction_voting.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_transaction_voting.py

Fabien requested changes to this revision.Apr 6 2022, 12:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc_p2p_avalanche_transaction_voting.py
50 ↗(On Diff #33100)

Use MiniWallet from test_framework.wallet. This has the benefit of working as well when the node has the -nowallet option:

# Make real txs
num_txs = 5
wallet = MiniWallet(node)
wallet.generate(num_txs)
        
# Mature the coinbases
node.generate(100)

assert_equal(node.getmempoolinfo()['size'], 0)
tx_ids = [int(wallet.send_self_transfer(from_node=node)['txid'], 16) for _ in range(num_txs)]
assert_equal(node.getmempoolinfo()['size'], num_txs)
This revision now requires changes to proceed.Apr 6 2022, 12:16
tyler-smith updated this revision to Diff 33106.Apr 6 2022, 16:29

Use MiniWallet for tests instead of the node's wallet.

Harbormaster completed remote builds in B18749: Diff 33106.Apr 6 2022, 16:45
Fabien added a comment.Apr 6 2022, 16:51

Please use a code block for your test plan (you can use a double space at the beginning of the line. Also the usual way is ./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting.py

Fabien requested changes to this revision.Apr 6 2022, 16:51
Fabien added inline comments.
test/functional/abc_p2p_avalanche_transaction_voting.py
16 ↗(On Diff #33106)

Use a more specialized name or we'll get tons of AvalancheTest classes

This revision now requires changes to proceed.Apr 6 2022, 16:51
tyler-smith edited the test plan for this revision. (Show Details)Apr 6 2022, 17:20
tyler-smith updated this revision to Diff 33108.Apr 6 2022, 17:20
tyler-smith edited the test plan for this revision. (Show Details)

Update test name.

Harbormaster completed remote builds in B18751: Diff 33108.Apr 6 2022, 17:35
Fabien added a comment.Apr 6 2022, 21:41

you reverted your test plan update

tyler-smith edited the test plan for this revision. (Show Details)Apr 11 2022, 06:35
Fabien accepted this revision.Apr 11 2022, 07:41

OK but please update the summary before you land to make it clear that it is a refactor only and an empty shell for future features:

  1. there is no change in behavior
  2. the test is not checking for the change (it will obviously work the same without this change)
This revision is now accepted and ready to land.Apr 11 2022, 07:41
Closed by commit rABC4549974dd90c: [avalanche] Handle tx inv polls with a stub handler. (authored by tyler-smith). · Explain WhyApr 12 2022, 04:38
This revision was automatically updated to reflect the committed changes.
tyler-smith added a commit: rABC4549974dd90c: [avalanche] Handle tx inv polls with a stub handler..

Revision Contents
Changeset List

PathSize
src/
17 lines
test/
functional/
70 lines

Diff 33160

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

Loading...