- User Since
- Dec 26 2018, 22:47 (183 w, 1 d)
May 1 2022
Remove code that is no longer necessary given the removal of IsWorthPolling(), and which is likely the cause of the test failures.
Fix accidental change-stack cross-contamination.
Remove incorrect, racy test assertion.
Apr 27 2022
Looks good. Left a comment to consider but not something that should hold up this changeset.
Move logging into lambda, make unparkBlock lambda, and add to tests.
Remove isAccepted contructor property and IsWorthPolling.
Apr 25 2022
@Fabien Let me know if there's something more you'd like to see regarding testing/test-plan for this change.
Apr 20 2022
Apr 19 2022
Superseded by D11367.
Looks correct other than a small comment typo.
Everything looks correctly implemented and the logic all makes sense, except I'm not clear on the reasoning about the quorum params.
Apr 17 2022
This is incorrect based on a misunderstanding with the peermanager and local proof.
300 is a lot more reasonable than 16 for a larger network.
Apr 13 2022
The idea and implementation are great, but I have a minor bikeshed-nit about naming. I don't think that nit should hold up acceptance but is worth considering.
This flag will be useful and the implementation looks correct.
Apr 12 2022
Apr 11 2022
Starting on line 2370 there is a breakdown of the overall algorithm here. I think we should update it to include this new behavior because it's specific enough that this change would make it incorrect.
The concept and implementation look good. A few nits with the test.
Apr 6 2022
Update test name.
Use MiniWallet for tests instead of the node's wallet.
Use a clean chain in tests.
Nice, this looks a good way to catch-all cleanup all disconnections.
The code makes sense and seems to be working. I can't tell why the build is failing it it appears to be unrelated to this change.
Mar 31 2022
This makes sense. Other nodes must always validate the proofs anyways.
Mar 30 2022
Makes sense and I don't see any reason it should affect the test logically.
Great idea so the quorum detection logic can stay encapsulated in the server.
In hindsight, this seems obvious. I think this fix and the tests are good.
The concept and implementation look correct and well-tested.
Mar 22 2022
Change looks correct.
Remove all changes to peermanager tests.
Remove unrelated change.
Use BOOST_CHECK instead of BOOST_CHECK_EQUAL to avoid passing the processor.
Address feedback. Add range checks to params, add failure cases, simplify tests, and remove unrelated cleanup changes.
Mar 21 2022
Fix remaining feedback, fix locale issues, and use proof orphaning to remove peers instead of needing their ids.
Mar 18 2022
Fix all review items except marking isQuorumEstablished as const, pending discussion.
Mar 17 2022
Update variable and method names.
Mar 16 2022
Fix tests and rebase onto latest D11118.
Fix unit test name.
Rename properties and improve tests.
Redesign to use pre-computed score amounts from D11181.
This functionality was included in a different changeset that landed.
Mar 13 2022
Spacing and test cleanup.
Fix missing newline at end of file.
Make comment style consistent and add space.
Update abc_p2p_getavaddr to allow a 0-stake quorum so node changes are processed.
Fix getavalancheinfo test by setting quorum min stake to 0. Otherwise, the eventloop never gets to the point of trying the disconnected nodes and never removes them from them so it keeps reporting 10.
Mar 12 2022
Update handling of min stake arg to avoid parsing issues with ToString()'d version.
Debugging remaining test failures.
Rebase onto master after dependency landed.
Include chrono in avalanche.h
Fix locale function linting issue by not trying to format double as a string.
Need to address new lint issue.
Rebase onto D11133 and address all oustanding feedback items.
Mar 11 2022
Concept and implementation both look good.
Make tests correctly disconnect peer nodes without hacks.
Mar 5 2022
Fix proof voting test.
Fix node vs peer stake comparison.
Implement ratio of connected nodes checking.
Update default parameters.
Feb 28 2022
Update arg names, fix unit tests, remove by_score handling, and start on peer stake ratio checking.