Page MenuHomePhabricator
Differential D11370

Use the actual config in the RPC console
ClosedPublic
Actions

Authored by Fabien on Apr 20 2022, 09:33.

Details

Reviewers
tyler-smith
Group Reviewers
Restricted Project
Commits
rABC22e87e805bfa: Use the actual config in the RPC console
Summary

The Qt RPC console uses a default config and causes the RPC to behave slightly differently than they do from bitcoind. This diff fixes that by forwarding the config at execution time.

Test Plan
ninja all check-all

On the RPC console, run getnewaddress and check it returns an ecash address (was a legacy one before the patch).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 20 2022, 09:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2022, 09:33
Fabien requested review of this revision.Apr 20 2022, 09:33
Harbormaster completed remote builds in B18846: Diff 33256.Apr 20 2022, 09:51
Mengerian added a subscriber: Mengerian.Apr 20 2022, 15:49

Just curious: Is this an issue in Bitcoin Core also? Should it be submitted as patch to Core?

Fabien added a comment.Apr 20 2022, 16:18
In D11370#254580, @Mengerian wrote:

Just curious: Is this an issue in Bitcoin Core also? Should it be submitted as patch to Core?

Core has no such Config object, so they're not affected

Fabien updated this revision to Diff 33262.Apr 20 2022, 16:33

Add a release note

Harbormaster completed remote builds in B18851: Diff 33262.Apr 20 2022, 16:49
tyler-smith accepted this revision.Apr 20 2022, 17:51
This revision is now accepted and ready to land.Apr 20 2022, 17:51
Closed by commit rABC22e87e805bfa: Use the actual config in the RPC console (authored by Fabien). · Explain WhyApr 20 2022, 17:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC22e87e805bfa: Use the actual config in the RPC console.

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
interfaces/
3 lines
2 lines
qt/
5 lines

Diff 33264

View Options

doc/release-notes.md

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...