Page MenuHomePhabricator

Use the actual config in the RPC console
ClosedPublic

Authored by Fabien on Apr 20 2022, 09:33.

Details

Reviewers
tyler-smith
Group Reviewers
Restricted Project
Commits
rABC22e87e805bfa: Use the actual config in the RPC console
Summary

The Qt RPC console uses a default config and causes the RPC to behave slightly differently than they do from bitcoind. This diff fixes that by forwarding the config at execution time.

Test Plan
ninja all check-all

On the RPC console, run getnewaddress and check it returns an ecash address (was a legacy one before the patch).

Event Timeline

Fabien requested review of this revision.Apr 20 2022, 09:33

Just curious: Is this an issue in Bitcoin Core also? Should it be submitted as patch to Core?

Just curious: Is this an issue in Bitcoin Core also? Should it be submitted as patch to Core?

Core has no such Config object, so they're not affected

This revision is now accepted and ready to land.Apr 20 2022, 17:51
This revision was automatically updated to reflect the committed changes.