[avalanche] Add mempool to Processor.
AbandonedPublic
Actions

Authored by Mengerian on Apr 20 2022, 13:17.

Details

Reviewers

Fabien
tyler-smith

Group Reviewers

Restricted Project

Summary

Expose the mempool to the Processor so we can resolve tx ids to CTransactionRefs. This revision only
adds access to the mempool, it does not use it yet.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

TS_tx_polling_2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18848
Build 37486: Build Diff	build-without-wallet · lint-circular-dependencies · build-diff · build-debug · build-clang-tidy · build-clang
Build 37485: arc lint + arc unit

Event Timeline

tyler-smith created this revision.Apr 20 2022, 13:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2022, 13:17

tyler-smith requested review of this revision.Apr 20 2022, 13:17

tyler-smith added a child revision: D11373: [avalanche] Send invs for known transactions..Apr 20 2022, 13:19

Harbormaster completed remote builds in B18848: Diff 33258.Apr 20 2022, 13:34

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: p2p_blockfilters.py ======

------- Stdout: -------
2022-04-20T13:28:13.072000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220420_132557/p2p_blockfilters_37
2022-04-20T13:28:17.760000Z TestFramework (INFO): get cfcheckpt on chain to be re-orged out.
2022-04-20T13:28:17.810000Z TestFramework (INFO): Reorg node 0 to a new chain.
2022-04-20T13:28:20.319000Z TestFramework (INFO): Check that peers can fetch cfcheckpt on active chain.
2022-04-20T13:28:20.369000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/p2p_blockfilters.py", line 110, in run_test
    assert_equal(response.stop_hash, request.stop_hash)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(9386259026753050100905703520366617513018591353737876744530273574334392105235 == 13332711430164624729644298508425401355568871820276559192164078696658058609925)
2022-04-20T13:28:20.420000Z TestFramework (INFO): Stopping nodes
2022-04-20T13:28:20.626000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220420_132557/p2p_blockfilters_37
2022-04-20T13:28:20.626000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220420_132557/p2p_blockfilters_37/test_framework.log
2022-04-20T13:28:20.626000Z TestFramework (ERROR): 
2022-04-20T13:28:20.626000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220420_132557/p2p_blockfilters_37' to consolidate all logs
2022-04-20T13:28:20.626000Z TestFramework (ERROR): 
2022-04-20T13:28:20.626000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-04-20T13:28:20.626000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-04-20T13:28:20.626000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_blockfilters.py

It's not clear to me what you expect to do from this. With the mempool you can retrieve transactions by id that are in the mempool, but not the txs from blocks, or orphans. What's the plan for these ?

src/avalanche/processor.h
98	Is that safe ? Also why not const ?
src/init.cpp
2595	At some point we should consider passing the node context directly rather than passing all its content one by one