Differential D11322

[avalanche] Send getavaaddr messages to the manually added nodes
ClosedPublic
Actions

Authored by Fabien on Apr 8 2022, 20:14.

Details

Reviewers

tyler-smith

Group Reviewers

Restricted Project

Commits

rABCe365dc8ab14e: [avalanche] Send getavaaddr messages to the manually added nodes

Summary

As per title, this makes it easier to test addresses propagation and make it possible to build private network. Only avalanche enabled peers are concerned.

Test Plan

./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 8 2022, 20:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 8 2022, 20:14

Fabien requested review of this revision.Apr 8 2022, 20:14

Harbormaster completed remote builds in B18761: Diff 33123.Apr 8 2022, 20:26

The concept and implementation look good. A few nits with the test.

test/functional/abc_p2p_getavaaddr.py
292 ↗	(On Diff #33123)	Unless I'm misunderstanding this part of the test this should say "not responding" right?
378 ↗	(On Diff #33123)	Should we clean this up?