Differential D11276

[avalanche] Keep sending getavaaddr until the qorum is established
ClosedPublic
Actions

Authored by Fabien on Mar 30 2022, 10:15.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC9d641e10f624: [avalanche] Keep sending getavaaddr until the qorum is established

Summary

The getavaaddr is conditionally sent when we failed to find a node to query. This is not working properly for the time where the quorum is not established yet as there is no attempt to select a node, altough that's the time we need them the most. This diff fixes this isse by issuing the getavaaddr request while the qorum is not esablished.

Ref T1864.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 30 2022, 10:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 30 2022, 10:15

Fabien requested review of this revision.Mar 30 2022, 10:15

Harbormaster completed remote builds in B18669: Diff 32987.Mar 30 2022, 10:34

Fabien added a child revision: D11277: [avalanche] Return addresses of nodes we did not poll yet.Mar 30 2022, 13:11

In hindsight, this seems obvious. I think this fix and the tests are good.

This revision is now accepted and ready to land.Mar 30 2022, 22:21

Closed by commit rABC9d641e10f624: [avalanche] Keep sending getavaaddr until the qorum is established (authored by Fabien). · Explain WhyMar 31 2022, 06:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9d641e10f624: [avalanche] Keep sending getavaaddr until the qorum is established.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

7 lines

test/

functional/

abc_p2p_getavaaddr.py

38 lines

Diff 33016

src/net_processing.cpp

Loading...

test/functional/abc_p2p_getavaaddr.py

Loading...