Page MenuHomePhabricator
Differential D11118

[TEST] Remove useless trailing parenthesis in class declaration
ClosedPublic
Actions

Authored by Fabien on Mar 1 2022, 15:37.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCbf53e2783c84: [TEST] Remove useless trailing parenthesis in class declaration
Summary

This probably comes from old python 2 memories, but this is not necessary, never was and is confusing at best so trim it off.

There is no change in behavior.

Test Plan
ninja check-functional-extended

cd test/functional
git grep -nE "class [^(]+\(\):"

Check there is no remaining case.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 1 2022, 15:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2022, 15:37
Fabien requested review of this revision.Mar 1 2022, 15:37
Harbormaster completed remote builds in B18383: Diff 32561.Mar 1 2022, 15:52
PiRK accepted this revision.Mar 1 2022, 15:59
PiRK added a subscriber: PiRK.

Great. It was also on my todo list.
I quickly looked for a way to detect these with a linter, but I didn't find an obvious error code to add to flake8.

This revision is now accepted and ready to land.Mar 1 2022, 15:59
Closed by commit rABCbf53e2783c84: [TEST] Remove useless trailing parenthesis in class declaration (authored by Fabien). · Explain WhyMar 1 2022, 17:04
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbf53e2783c84: [TEST] Remove useless trailing parenthesis in class declaration.
tyler-smith mentioned this in D11101: [avalanche] Don't poll or vote definitively until we have quorum..Mar 16 2022, 22:50

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
2 lines
2 lines
test_framework/
2 lines
2 lines
4 lines
20 lines
8 lines
6 lines
8 lines

Diff 32562

View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/abc_p2p_compactblocks.py

Loading...
View Options

test/functional/abc_p2p_fullblocktest.py

Loading...
View Options

test/functional/test_framework/authproxy.py

Loading...
View Options

test/functional/test_framework/coverage.py

Loading...
View Options

test/functional/test_framework/key.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...
View Options

test/functional/test_framework/socks5.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_runner.py

Loading...