Page MenuHomePhabricator

doc: Remove irrelevant link to GitHub
ClosedPublic

Authored by PiRK on Apr 13 2022, 13:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC59336299e3fa: doc: Remove irrelevant link to GitHub
Summary

The doc nicely explains why the directory exists and it is irrelevant when it was introduced. Even if it was relevant, it could be trivially found out via git log ./src/node/ | tail without visiting GitHub

This concludes backport of core#21575 [6/6]
https://github.com/bitcoin/bitcoin/pull/21575/commits/fadcd3f78e1dd1acd7a774f8fad68dc471ff9e1f

Test Plan

NA

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Apr 13 2022, 13:12

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 13 2022, 13:43

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "node/blockstorage -> validation -> txdb -> node/blockstorage" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1
PiRK planned changes to this revision.Apr 25 2022, 13:22
Fabien requested changes to this revision.Apr 25 2022, 14:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/README.md
19 ↗(On Diff #33303)

This line break is now at the wrong place

This revision now requires changes to proceed.Apr 25 2022, 14:49
PiRK edited the summary of this revision. (Show Details)

Fixed layout and added missing backport information to summary.

This revision is now accepted and ready to land.Apr 26 2022, 06:56
This revision was automatically updated to reflect the committed changes.