Page MenuHomePhabricator
Differential D11390

[avalanche] Bypass net group limits by default for avalanche outbounds
AbandonedPublic
Actions

Authored by Fabien on Apr 27 2022, 08:47.

Details

Reviewers
sdulfari
deadalnix
Group Reviewers
Restricted Project
Summary

The node will restrict the outbound nodes by network group to avoid connecting to nodes from the same area before it connects to other outbounds. This behavior is not desirable for avalanche so we can turn it off. The node eviction mechanism will take care to balance the net groups already if we are running out of slots.

Since D11340 there already is a flag to turn the feature on or off. This diff sets to default to true for avalanche outbound peers only so there is no change in behavior if avalanche is not enabled.

Test Plan
ninja all check-all

Run IBD.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_bypass_network_limit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18897
Build 37577: Build Difflint-circular-dependencies · build-diff · build-without-wallet · build-clang-tidy · build-clang · build-debug
Build 37576: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 27 2022, 08:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2022, 08:47
Fabien requested review of this revision.Apr 27 2022, 08:47
Fabien planned changes to this revision.Apr 27 2022, 08:48

@bot build-ibd

teamcity awarded a token.Apr 27 2022, 08:48
Harbormaster completed remote builds in B18897: Diff 33321.Apr 27 2022, 09:03
Fabien requested review of this revision.Apr 28 2022, 14:12
sdulfari requested changes to this revision.Apr 28 2022, 20:24
sdulfari added a subscriber: sdulfari.

This single flag is trying to do two jobs, so it ends up being a tri-state switch, which I doubt is expected by the user:

  • Unset - non-avalanche connections do not bypass, but avalanche connections do
  • True - all connections bypass
  • False - no connections bypass

The patch is suggesting that you may want to configure the bypass by connection type.

In the interest of time, I'm willing to accept this patch if this issue is at least acknowledged in a comment. Exploring improvements to this config can happen in parallel with avalanche development.

This revision now requires changes to proceed.Apr 28 2022, 20:24
sdulfari mentioned this in D11340: Add an option to allow for bypassing the network group limit on outbound connections.Apr 28 2022, 21:06
deadalnix requested changes to this revision.Apr 28 2022, 22:25
deadalnix added a subscriber: deadalnix.

Also, the test plan doesn't test the change.

Fabien abandoned this revision.Nov 22 2022, 07:53

Revision Contents
Changeset List

PathSize
src/
3 lines

Diff 33321

View Options

src/net.cpp

Loading...