Ability to import a CSV contact list previously exported from Cashtab.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
- npm start
- add a few addresses to the contact list
- click Export Contacts and save the csv file
- clear browser cache (backup your seeds)
- create new wallet, open contact list again and click Import Contacts and choose the csv file exported from Cashtab, and ensure successful population of contacts
- ensure the open file dialogue only displays the .csv files on the user's local filesystem
- edit one of the contacts so that the '|' delimiter is contained in their name and export this updated contact list via csv.
- clear browser cache (backup your seeds)
- create new wallet, import the csv export from cashtab with a contact name containing the delimiter and ensure the name and addresses are still parsed correctly
- attempt to import a malformed csv file and ensure error validation notification
- clear browser cache again
- import a wallet this time, repeat step 5 and ensure no errors
- ensure only the New Contact and Import Contacts buttons are rendered on an empty contact list dropdown
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- importContacts
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 18944 Build 37656: Build Diff cashtab-tests Build 37655: arc lint + arc unit
Event Timeline
Comment Actions
This is a neat feature but it's also a pretty significant complication to the app. I'm not sure the ROI is there for getting this in.
Another question -- would it be better to just have "export wallet" and "import wallet" as a function (including all wallets, settings, and contacts), and lose the "export contacts"? This would have more utility (esp for users with multiple wallets). Once that is a feature, arguable that import/export of contacts is not worthwhile.
Let's table this for now while we hammer out the chronik details.
Comment Actions
Please abandon this diff as we won't land this in its current form. It's a good placeholder in case we choose to have more broad export functionality in the future.