Differential D11421

Add a traversal method for the radix tree
ClosedPublic
Actions

Authored by Fabien on May 5 2022, 15:06.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCf9e31f734c34: Add a traversal method for the radix tree

Summary

This method applies a callback to each Leaf in the ascending key order.

It is expected to be used for several purposes:

With compact proof requests to compute the short ids
With the mempool to fill the getblocktemplate

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_radix_tree_traversal

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18954
Build 37673: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 37672: arc lint + arc unit

Event Timeline

Fabien created this revision.May 5 2022, 15:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2022, 15:06

Fabien requested review of this revision.May 5 2022, 15:06

Harbormaster completed remote builds in B18954: Diff 33406.May 5 2022, 15:26

A quick mention of what you intend to do with this would be helpful since it's not currently used except for its own test.

src/radix.h
140	public is redundant here

This revision now requires changes to proceed.May 5 2022, 16:42

Fabien edited the summary of this revision. (Show Details)May 5 2022, 17:41

Remove redundant public and expand the summary with a couple expected use cases.

Harbormaster completed remote builds in B18960: Diff 33417.May 5 2022, 17:56

sdulfari accepted this revision.May 5 2022, 18:35

This revision is now accepted and ready to land.May 5 2022, 18:35

Closed by commit rABCf9e31f734c34: Add a traversal method for the radix tree (authored by Fabien). · Explain WhyMay 6 2022, 09:14

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf9e31f734c34: Add a traversal method for the radix tree.

Revision Contents
Changeset List

Path

Size

src/

radix.h

26 lines

test/

radix_tests.cpp

33 lines

Diff 33406

View Options

src/radix.h