Differential D11456

[radix] Adds the capability to use an adapter for key manipulation
ClosedPublic
Actions

Authored by Fabien on May 12 2022, 19:18.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC55e8d25097ba: [radix] Adds the capability to use an adapter for key manipulation

Summary

This allow to use element which do not have a getId memeber, or do not have a valid key type in the tree.

Test Plan

ninja check-bitcoin-radix_tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 12 2022, 19:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2022, 19:18

deadalnix requested review of this revision.May 12 2022, 19:18

deadalnix mentioned this in D11450: [avalanche] Maintain a radix tree of the proofs.May 12 2022, 19:18

Harbormaster completed remote builds in B19013: Diff 33499.May 12 2022, 19:34

Fabien commandeered this revision.May 14 2022, 01:25

Fabien added a reviewer: deadalnix.

Add one missing conversion and unit test

Harbormaster completed remote builds in B19032: Diff 33521.May 14 2022, 01:43

deadalnix accepted this revision.May 19 2022, 17:49

deadalnix added inline comments.

src/radix.h
414 ↗	(On Diff #33521)	This should be moved out of here as a next step.
src/test/radix_tests.cpp
607 ↗	(On Diff #33521)	Shouldn't this be BOOST_REQUIRE? We are not trying to test ParseUint64 here.

This revision is now accepted and ready to land.May 19 2022, 17:49

Closed by commit rABC55e8d25097ba: [radix] Adds the capability to use an adapter for key manipulation (authored by Fabien). · Explain WhyMay 19 2022, 18:23

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC55e8d25097ba: [radix] Adds the capability to use an adapter for key manipulation.

Revision Contents
Changeset List

Path

Size

src/

22 lines

test/

radix_tests.cpp

47 lines

Diff 33628

src/radix.h

Loading...

src/test/radix_tests.cpp

Loading...