Page MenuHomePhabricator

[avalanche] Maintain a count of the proofs in the proof pool
AbandonedPublic

Authored by Fabien on May 19 2022, 10:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This count cannot be simply retrieved using size() because it is a multimap like structure. This will be later used to limit the pool size.

Test Plan
ninja check-avalanche

Diff Detail

Event Timeline

Fabien requested review of this revision.May 19 2022, 10:40
Fabien planned changes to this revision.May 19 2022, 15:44

Reset the counter on rescan

deadalnix requested changes to this revision.May 19 2022, 17:42
deadalnix added a subscriber: deadalnix.

This count cannot be simply retrieved using size() because it is a multimap like structure.

It doesn't looks like this is solving any problem:

  • It appears from the existing code that the size of the multimap can indeed be retrieved from the multimap
  • If that is somehow not what we want, then in what way? What problem do we have that require tracking this independently from the multimap?

It seems that the only major thing this diff achieve is to introduce the ability to get the count wrong, which was impossible by design before. It doesn't looks like to me that this is a desirable feature.

This revision now requires changes to proceed.May 19 2022, 17:42