Differential D11499

[avalanche] Move VoteRecord tests to their own file
ClosedPublic
Actions

Authored by sdulfari on May 19 2022, 16:56.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4f6a0d53c689: [avalanche] Move VoteRecord tests to their own file

Summary

VoteRecord needs better test coverage on its own. Shoveling more tests into processor_tests is bad idea,
so this patch separates VoteRecord tests into their own file.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

vr-tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19111
Build 37970: Build Diff	build-diff · build-without-wallet · lint-circular-dependencies · build-clang-tidy · build-debug · build-clang
Build 37969: arc lint + arc unit

Event Timeline

sdulfari created this revision.May 19 2022, 16:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2022, 16:56

sdulfari requested review of this revision.May 19 2022, 16:56

Harbormaster completed remote builds in B19111: Diff 33626.May 19 2022, 17:11

deadalnix accepted this revision.May 19 2022, 17:37

This revision is now accepted and ready to land.May 19 2022, 17:37

sdulfari added a child revision: D11500: [avalanche] Add some tests to check that duplicate votes are not counted.May 19 2022, 18:09

Closed by commit rABC4f6a0d53c689: [avalanche] Move VoteRecord tests to their own file (authored by sdulfari). · Explain WhyMay 19 2022, 18:34

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC4f6a0d53c689: [avalanche] Move VoteRecord tests to their own file.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

1 line

processor_tests.cpp

106 lines

voterecord_tests.cpp

121 lines

Diff 33626

src/avalanche/test/CMakeLists.txt

Loading...

src/avalanche/test/processor_tests.cpp

Loading...

src/avalanche/test/voterecord_tests.cpp

Loading...