rpc/blockchain: Use existing NodeContext
ClosedPublic
Actions

Authored by PiRK on May 20 2022, 14:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC053eb6c9cd7f: rpc/blockchain: Use existing NodeContext

Summary

Also pass in appropriate object to: BIP9SoftForkDescPushBack

PR context: De-globalize ChainstateManager

This is a backport of core#21391
https://github.com/bitcoin/bitcoin/pull/21391/commits/d485e815e2b62dc74a485569d08130dc3ef9ff63

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.May 20 2022, 14:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2022, 14:49

PiRK requested review of this revision.May 20 2022, 14:49

teamcity edited the summary of this revision. (Show Details)May 20 2022, 14:49

Harbormaster completed remote builds in B19123: Diff 33645.May 20 2022, 15:17

There are more simplifications:

chainman.ActiveChain().Tip -> chainman.ActiveTip()
chainman.ActiveChain().Height() -> chainman.ActiveHeight()

use chainman.ActiveTip() and chainman.ActiveHeight() as suggested by John Newberry in his late review of the source commit.

Harbormaster completed remote builds in B19127: Diff 33650.May 20 2022, 17:16

Fabien accepted this revision.May 23 2022, 12:45

This revision is now accepted and ready to land.May 23 2022, 12:45

Closed by commit rABC053eb6c9cd7f: rpc/blockchain: Use existing NodeContext (authored by Carl Dong <contact@carldong.me>, committed by PiRK). · Explain WhyMay 23 2022, 15:49

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC053eb6c9cd7f: rpc/blockchain: Use existing NodeContext.

Revision Contents
Changeset List

Path

Size

src/

rpc/

blockchain.cpp

171 lines

Diff 33672

View Options

rpc/blockchain: Use existing NodeContextClosedPublicActions