Page MenuHomePhabricator
Differential D11516

Deduplicate the HasReason class
ClosedPublic
Actions

Authored by Fabien on May 23 2022, 19:00.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC28fee18339ae: Deduplicate the HasReason class
Summary

It's defined in setup_common.h but also in blockencodings_tests.cpp which is unnecessary.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 23 2022, 19:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2022, 19:00
Fabien requested review of this revision.May 23 2022, 19:00
Harbormaster completed remote builds in B19143: Diff 33678.May 23 2022, 19:29
sdulfari accepted this revision.May 23 2022, 21:55
This revision is now accepted and ready to land.May 23 2022, 21:55
Closed by commit rABC28fee18339ae: Deduplicate the HasReason class (authored by Fabien). · Explain WhyMay 24 2022, 07:25
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC28fee18339ae: Deduplicate the HasReason class.

Revision Contents
Changeset List

PathSize
src/
test/
12 lines

Diff 33682

View Options

src/test/blockencodings_tests.cpp

Loading...