Page MenuHomePhabricator
Differential D11552

remove unused class util::Ref and its unit test
ClosedPublic
Actions

Authored by PiRK on Jun 1 2022, 14:34.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCdeb8ab9f4df9: remove unused class util::Ref and its unit test
Summary

This concludes backport of core#21366
https://github.com/bitcoin/bitcoin/pull/21366/commits/916ab0195d567fd0a9097045e73a6654c453adea

Depends on D11551

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 1 2022, 14:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 1 2022, 14:34
PiRK requested review of this revision.Jun 1 2022, 14:34
teamcity edited the summary of this revision. (Show Details)Jun 1 2022, 14:34
PiRK edited the summary of this revision. (Show Details)Jun 1 2022, 14:38
PiRK added a parent revision: D11551: refactor: replace util::Ref with std::any (C++17).
Harbormaster completed remote builds in B19217: Diff 33769.Jun 1 2022, 14:55
teamcity added a comment.Jun 1 2022, 14:55
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[347/519] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[348/519] Linking C static library src/secp256k1/libsecp256k1.a
[349/519] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[350/519] Linking CXX static library src/libbitcoinconsensus.a
[351/519] Linking C executable src/secp256k1/ecmult-bench
[352/519] Linking CXX static library src/libscript.a
[353/519] Linking C executable src/secp256k1/internal-bench
[354/519] Linking C executable src/secp256k1/sign-bench
[355/519] Linking CXX static library src/libcommon.a
[356/519] Linking C executable src/secp256k1/verify-bench
[357/519] Linking CXX shared library src/libbitcoinconsensus.so.0.25.7
[358/519] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[359/519] Linking C executable src/secp256k1/recover-bench
[360/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[361/519] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[362/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[363/519] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[364/519] Linking CXX executable src/bitcoin-cli
[365/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[366/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[367/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[368/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[369/519] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[370/519] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[371/519] Linking CXX executable src/bitcoin-tx
[372/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[373/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[374/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[375/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[376/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[377/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[378/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[379/519] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[380/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[381/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[382/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[383/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[384/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[385/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[386/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[387/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[388/519] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[389/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[390/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[391/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[392/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[393/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[394/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[395/519] Linking CXX static library src/wallet/libwallet.a
[396/519] Linking CXX static library src/wallet/libwallet-tool.a
[397/519] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Jun 1 2022, 14:56
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[339/517] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[340/517] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[341/517] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[342/517] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[343/517] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[344/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[345/517] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[346/517] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[347/517] Linking C static library src/secp256k1/libsecp256k1.a
[348/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[349/517] Linking CXX static library src/libbitcoinconsensus.a
[350/517] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[351/517] Linking C executable src/secp256k1/ecmult-bench
[352/517] Linking C executable src/secp256k1/internal-bench
[353/517] Linking CXX static library src/libscript.a
[354/517] Linking C executable src/secp256k1/verify-bench
[355/517] Linking C executable src/secp256k1/sign-bench
[356/517] Linking C executable src/secp256k1/recover-bench
[357/517] Linking CXX static library src/libcommon.a
[358/517] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[359/517] Linking CXX shared library src/libbitcoinconsensus.so.0.25.7
[360/517] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[361/517] Linking CXX executable src/bitcoin-cli
[362/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[363/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[364/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[365/517] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[366/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[367/517] Linking CXX executable src/bitcoin-tx
[368/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[369/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[370/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[371/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[372/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[373/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[374/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[375/517] Linking CXX static library src/zmq/libzmq.a
[376/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[377/517] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[378/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[379/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[380/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[381/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[382/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[383/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[384/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[385/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[386/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[387/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[388/517] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[389/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[390/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[391/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[392/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[393/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[394/517] Linking CXX static library src/wallet/libwallet.a
[395/517] Linking CXX static library src/wallet/libwallet-tool.a
[396/517] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK planned changes to this revision.Jun 1 2022, 15:03
PiRK updated this revision to Diff 33772.Jun 1 2022, 15:29

rebase

Harbormaster completed remote builds in B19220: Diff 33772.Jun 1 2022, 15:33
teamcity added a comment.Jun 1 2022, 15:33
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[347/519] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[348/519] Linking C static library src/secp256k1/libsecp256k1.a
[349/519] Linking CXX static library src/libbitcoinconsensus.a
[350/519] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[351/519] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[352/519] Linking CXX static library src/libscript.a
[353/519] Linking C executable src/secp256k1/ecmult-bench
[354/519] Linking C executable src/secp256k1/internal-bench
[355/519] Linking C executable src/secp256k1/sign-bench
[356/519] Linking C executable src/secp256k1/verify-bench
[357/519] Linking CXX static library src/libcommon.a
[358/519] Linking C executable src/secp256k1/recover-bench
[359/519] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[360/519] Linking CXX shared library src/libbitcoinconsensus.so.0.25.7
[361/519] Linking CXX executable src/bitcoin-cli
[362/519] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[363/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[364/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[365/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[366/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[367/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[368/519] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[369/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[370/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[371/519] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[372/519] Linking CXX executable src/bitcoin-tx
[373/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[374/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[375/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[376/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[377/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[378/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[379/519] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[380/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[381/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[382/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[383/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[384/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[385/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[386/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[387/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[388/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[389/519] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[390/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[391/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[392/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[393/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[394/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[395/519] Linking CXX static library src/wallet/libwallet.a
[396/519] Linking CXX static library src/wallet/libwallet-tool.a
[397/519] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Jun 1 2022, 15:35
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[339/517] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[340/517] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[341/517] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[342/517] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[343/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[344/517] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[345/517] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[346/517] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[347/517] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[348/517] Linking C static library src/secp256k1/libsecp256k1.a
[349/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[350/517] Linking CXX static library src/libbitcoinconsensus.a
[351/517] Linking CXX static library src/libscript.a
[352/517] Linking C executable src/secp256k1/ecmult-bench
[353/517] Linking C executable src/secp256k1/internal-bench
[354/517] Linking CXX static library src/libcommon.a
[355/517] Linking C executable src/secp256k1/sign-bench
[356/517] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[357/517] Linking C executable src/secp256k1/verify-bench
[358/517] Linking CXX shared library src/libbitcoinconsensus.so.0.25.7
[359/517] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[360/517] Linking C executable src/secp256k1/recover-bench
[361/517] Linking CXX executable src/bitcoin-cli
[362/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[363/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[364/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[365/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[366/517] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[367/517] Linking CXX executable src/bitcoin-tx
[368/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[369/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[370/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[371/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[372/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[373/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[374/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[375/517] Linking CXX static library src/zmq/libzmq.a
[376/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[377/517] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[378/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[379/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[380/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[381/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[382/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[383/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[384/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[385/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[386/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[387/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[388/517] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[389/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[390/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[391/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[392/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[393/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[394/517] Linking CXX static library src/wallet/libwallet.a
[395/517] Linking CXX static library src/wallet/libwallet-tool.a
[396/517] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK updated this revision to Diff 33775.Jun 1 2022, 15:41

rebase

Harbormaster completed remote builds in B19223: Diff 33775.Jun 1 2022, 15:49
teamcity added a comment.Jun 1 2022, 15:49
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[339/517] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[340/517] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[341/517] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[342/517] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[343/517] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[344/517] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[345/517] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[346/517] Linking C static library src/secp256k1/libsecp256k1.a
[347/517] Linking CXX static library src/libbitcoinconsensus.a
[348/517] Linking C executable src/secp256k1/ecmult-bench
[349/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[350/517] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[351/517] Linking C executable src/secp256k1/internal-bench
[352/517] Linking C executable src/secp256k1/verify-bench
[353/517] Linking C executable src/secp256k1/sign-bench
[354/517] Linking C executable src/secp256k1/recover-bench
[355/517] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[356/517] Linking CXX static library src/libscript.a
[357/517] Linking CXX static library src/libcommon.a
[358/517] Linking CXX shared library src/libbitcoinconsensus.so.0.25.7
[359/517] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[360/517] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[361/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[362/517] Linking CXX executable src/bitcoin-cli
[363/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[364/517] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[365/517] Linking CXX executable src/bitcoin-tx
[366/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[367/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[368/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[369/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[370/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[371/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[372/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[373/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[374/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[375/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[376/517] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[377/517] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[378/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[379/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[380/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[381/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[382/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[383/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[384/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[385/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[386/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[387/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[388/517] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[389/517] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[390/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[391/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[392/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[393/517] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[394/517] Linking CXX static library src/wallet/libwallet.a
[395/517] Linking CXX static library src/wallet/libwallet-tool.a
[396/517] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Jun 1 2022, 15:50
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[347/519] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[348/519] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[349/519] Linking C static library src/secp256k1/libsecp256k1.a
[350/519] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[351/519] Linking CXX static library src/libbitcoinconsensus.a
[352/519] Linking C executable src/secp256k1/ecmult-bench
[353/519] Linking CXX static library src/libscript.a
[354/519] Linking C executable src/secp256k1/internal-bench
[355/519] Linking CXX static library src/libcommon.a
[356/519] Linking C executable src/secp256k1/sign-bench
[357/519] Linking CXX shared library src/libbitcoinconsensus.so.0.25.7
[358/519] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[359/519] Linking CXX executable src/bitcoin-cli
[360/519] Linking C executable src/secp256k1/verify-bench
[361/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[362/519] Linking C executable src/secp256k1/recover-bench
[363/519] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[364/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[365/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[366/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[367/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[368/519] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[369/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[370/519] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[371/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[372/519] Linking CXX executable src/bitcoin-tx
[373/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[374/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[375/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[376/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[377/519] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[378/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[379/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[380/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[381/519] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[382/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[383/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[384/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[385/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[386/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[387/519] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[388/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[389/519] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[390/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[391/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[392/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[393/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[394/519] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[395/519] Linking CXX static library src/wallet/libwallet.a
[396/519] Linking CXX static library src/wallet/libwallet-tool.a
[397/519] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
sdulfari accepted this revision.Jun 1 2022, 16:44
sdulfari added a subscriber: sdulfari.

This change looks ok, so long as D11551 gets fixed and tests pass when you rebase.

This revision is now accepted and ready to land.Jun 1 2022, 16:44
PiRK updated this revision to Diff 33794.Jun 2 2022, 16:11

rebase

PiRK added a child revision: D11560: Drop JSONRPCRequest constructors.Jun 2 2022, 16:13
Harbormaster completed remote builds in B19238: Diff 33794.Jun 2 2022, 16:36
Closed by commit rABCdeb8ab9f4df9: remove unused class util::Ref and its unit test (authored by PiRK). · Explain WhyJun 3 2022, 11:39
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCdeb8ab9f4df9: remove unused class util::Ref and its unit test.

Revision Contents
Changeset List

PathSize
src/
test/
1 line
util/

Diff 33806

View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/ref_tests.cpp

Loading...
View Options

src/util/ref.h

Loading...