Differential D11619

[avalanche] Integrate the IBD check into the quorum check
ClosedPublic
Actions

Authored by Fabien on Jun 13 2022, 13:31.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCd7c91e5a488d: [avalanche] Integrate the IBD check into the quorum check

Summary

Because the proofs can't be relied upon until we are synced, considering the quorum valid before the end of IBD is a non sense. This will also prevent the node from voting when not synced (added test).

Depends on D11618.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 13 2022, 13:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 13 2022, 13:31

Fabien requested review of this revision.Jun 13 2022, 13:31

Harbormaster completed remote builds in B19380: Diff 33995.Jun 13 2022, 13:42

sdulfari accepted this revision.Jun 13 2022, 18:40

This revision is now accepted and ready to land.Jun 13 2022, 18:40

Closed by commit rABCd7c91e5a488d: [avalanche] Integrate the IBD check into the quorum check (authored by Fabien). · Explain WhyJun 13 2022, 19:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCd7c91e5a488d: [avalanche] Integrate the IBD check into the quorum check.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

processor.cpp

10 lines

test/

functional/

abc_p2p_avalanche_quorum.py

42 lines

Diff 34015

View Options

src/avalanche/processor.cpp