Differential D11665

[avalanche] Use immature UTXO to orphan the proof in known_score_tracking test
ClosedPublic
Actions

Authored by sdulfari on Jun 23 2022, 22:26.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC2011942b89d4: [avalanche] Use immature UTXO to orphan the proof in known_score_tracking test

Summary

Since D11622, orphans can have valid UTXOs but not be mature enough to be valid.
The next major step is to limit the orphan pool to only immature proofs and not
accept proofs with missing UTXOs.

This patch prepares us for that change by migrating one of the instances of a
peer manager test that uses an orphan proof with a missing UTXO to use an
immature one instead. This will make review of the the future immature-only
orphan pool patch simpler since this change is self-contained.

Depends on D11622 and D11664

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Jun 23 2022, 22:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 23 2022, 22:26

sdulfari requested review of this revision.Jun 23 2022, 22:26

Harbormaster completed remote builds in B19462: Diff 34116.Jun 23 2022, 22:38

Fabien accepted this revision.Jun 24 2022, 13:20

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/test/peermanager_tests.cpp
1552 ↗	(On Diff #34116)	Please add a comment to explain the created utxo here is immature, and so peer1proof3 is an orphan

This revision is now accepted and ready to land.Jun 24 2022, 13:20

Add comment per feedback

Fabien accepted this revision.Jun 24 2022, 15:50

Harbormaster completed remote builds in B19470: Diff 34130.Jun 24 2022, 16:38

Rebase on latest D11622 (and fix off-by-one conf)

sdulfari edited the summary of this revision. (Show Details)Jun 24 2022, 17:21

Harbormaster completed remote builds in B19472: Diff 34133.Jun 24 2022, 17:52

Closed by commit rABC2011942b89d4: [avalanche] Use immature UTXO to orphan the proof in known_score_tracking test (authored by sdulfari). · Explain WhyJun 24 2022, 19:25

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC2011942b89d4: [avalanche] Use immature UTXO to orphan the proof in known_score_tracking test.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

22 lines

Diff 34135

src/avalanche/test/peermanager_tests.cpp

Loading...