Page MenuHomePhabricator
Differential D11734

[avalanche] Fix flaky checks after orphaning a valid proof
ClosedPublic
Actions

Authored by sdulfari on Jul 8 2022, 18:30.

Details

Reviewers
PiRK
Fabien
Group Reviewers
Restricted Project
Commits
rABC7d9f34c53fd1: [avalanche] Fix flaky checks after orphaning a valid proof
Summary

This test occasionally fails when UpdatedBlockTip has been queued but not yet called, resulting in the proof still returning as not orphaned during the getrawavalancheproof call.

Test Plan
for i in {1..20} ; do ./test/functional/test_runner.py abc_rpc_avalancheproof.py ; done

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.Jul 8 2022, 18:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 8 2022, 18:30
sdulfari requested review of this revision.Jul 8 2022, 18:30
Harbormaster completed remote builds in B19607: Diff 34319.Jul 8 2022, 18:46
PiRK accepted this revision.Jul 11 2022, 06:56
This revision is now accepted and ready to land.Jul 11 2022, 06:56
Fabien requested changes to this revision.Jul 11 2022, 07:21
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/abc_rpc_avalancheproof.py
492 ↗(On Diff #34319)

I think you want to use node.syncwithvalidationinterfacequeue()

This revision now requires changes to proceed.Jul 11 2022, 07:21
sdulfari updated this revision to Diff 34329.Jul 11 2022, 18:22

Feedback

Harbormaster completed remote builds in B19614: Diff 34329.Jul 11 2022, 18:39
Fabien accepted this revision.Jul 11 2022, 18:51
This revision is now accepted and ready to land.Jul 11 2022, 18:51
Closed by commit rABC7d9f34c53fd1: [avalanche] Fix flaky checks after orphaning a valid proof (authored by sdulfari). · Explain WhyJul 11 2022, 19:07
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC7d9f34c53fd1: [avalanche] Fix flaky checks after orphaning a valid proof.

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines

Diff 34332

View Options

test/functional/abc_rpc_avalancheproof.py

Loading...