Page MenuHomePhabricator

[avalanche] Don't register known dangling proofs
ClosedPublic

Authored by Fabien on Jul 12 2022, 15:34.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC771ec1ef4a05: [avalanche] Don't register known dangling proofs
Summary

After a dangling proof has been evicted, the node should not accept it again unless it finally has a node pending for it. This prevents from downloading again a proof that never gets attached to a node.

The proof ids are stored in a rolling bloom filter so the memory usage is bound. Since a false positive in that filter is not critical, the parameters are chosen to keep the memory usage low (about 10kB).

Test Plan
ninja all check-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_remember_evicted_proofs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19618
Build 38955: Build Diffbuild-debug · lint-circular-dependencies · build-diff · build-without-wallet · build-clang · build-clang-tidy
Build 38954: arc lint + arc unit