Page MenuHomePhabricator

[Cashtab] Change toSmallestDenomination and fromSmallestDenomination function names
AbandonedPublic

Authored by kieran709 on Jul 27 2022, 15:46.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Related to task T2583. Changed function names of toSmallestDenomination and fromSmallestDenomination to toSatoshis and fromSatoshis respectively.

Test Plan

cd web/cashtab
grep -r 'fromSmallestDenomination' src/ should return no results
grep -r 'toSmallestDenomination' src/ should return no results

Diff Detail

Repository
rABC Bitcoin ABC
Branch
change-function-names
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19740
Build 39199: Build Diffcashtab-tests
Build 39198: arc lint + arc unit

Event Timeline

This looks good. I should have specified we should do this after we get the significant sendXec refactor in, as this will cause substantial rebase conflict complications with that work

So -- sit on this for now