Page MenuHomePhabricator

[avalanche] Increase proof dust threshold
ClosedPublic

Authored by sdulfari on Aug 4 2022, 22:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf33eb4f5aa97: [avalanche] Increase proof dust threshold
Summary

The proof dust threshold is too low to provide reliable counter-incentives in all scenarios. This patch increases it by a factor of 100.

Depends on D11750

Test Plan
ninja check check-extended

Diff Detail

Event Timeline

sdulfari requested review of this revision.Aug 4 2022, 22:50

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_proof_voting.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-04T22:54:34.620000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220804_225313/abc_p2p_avalanche_proof_voting_14
2022-08-04T22:54:37.286000Z TestFramework (INFO): Trigger polling from the node...
2022-08-04T22:54:37.448000Z TestFramework (INFO): Check we poll for valid proof
2022-08-04T22:54:37.593000Z TestFramework (INFO): Check we don't poll for subsequent proofs if the cooldown is not elapsed, proof not the favorite
2022-08-04T22:54:37.645000Z TestFramework (INFO): Check we don't poll for subsequent proofs if the cooldown is not elapsed, proof is the favorite
2022-08-04T22:54:37.696000Z TestFramework (INFO): Check we poll for conflicting proof if the proof is not the favorite
2022-08-04T22:54:37.853000Z TestFramework (INFO): Check we poll for conflicting proof if the proof is the favorite
2022-08-04T22:55:37.888000Z TestFramework.utils (ERROR): wait_until() failed. Predicate: ''''
        self.wait_until(lambda: self.can_find_proof_in_poll(proofid, response))
'''
2022-08-04T22:55:37.888000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_proof_voting.py", line 118, in run_test
    self.poll_tests(node)
  File "/work/test/functional/abc_p2p_avalanche_proof_voting.py", line 174, in poll_tests
    self.send_and_check_for_polling(peer, proof_seq40)
  File "/work/test/functional/abc_p2p_avalanche_proof_voting.py", line 94, in send_and_check_for_polling
    self.wait_until(lambda: self.can_find_proof_in_poll(proofid, response))
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 284, in wait_until_helper
    "Predicate {} not true after {} seconds".format(predicate_source, timeout))
AssertionError: Predicate ''''
        self.wait_until(lambda: self.can_find_proof_in_poll(proofid, response))
''' not true after 60.0 seconds
2022-08-04T22:55:37.939000Z TestFramework (INFO): Stopping nodes
2022-08-04T22:55:38.091000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220804_225313/abc_p2p_avalanche_proof_voting_14
2022-08-04T22:55:38.091000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220804_225313/abc_p2p_avalanche_proof_voting_14/test_framework.log
2022-08-04T22:55:38.092000Z TestFramework (ERROR): 
2022-08-04T22:55:38.092000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220804_225313/abc_p2p_avalanche_proof_voting_14' to consolidate all logs
2022-08-04T22:55:38.092000Z TestFramework (ERROR): 
2022-08-04T22:55:38.092000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-04T22:55:38.092000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-04T22:55:38.092000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_proof_voting.py --nolegacyavaproof

This revision is now accepted and ready to land.Aug 5 2022, 09:18
This revision was automatically updated to reflect the committed changes.