Differential D11833

Fix a race in the net tests
ClosedPublic
Actions

Authored by Fabien on Aug 8 2022, 09:35.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC12677a9f321d: Fix a race in the net tests

Summary

There is a possible race that can occur when looping over the nodes while the opening connection thread is running. This can be fixed by joining the thread before running the check.

Test Plan

Run the tsan build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 8 2022, 09:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 8 2022, 09:35

Fabien requested review of this revision.Aug 8 2022, 09:35

@bot build-tsan

teamcity awarded a token.Aug 8 2022, 09:35

Fabien mentioned this in D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.Aug 8 2022, 09:39

Fabien added a child revision: D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.Aug 8 2022, 09:41

Harbormaster completed remote builds in B19784: Diff 34601.Aug 8 2022, 09:52

sdulfari accepted this revision.Aug 8 2022, 15:49

This revision is now accepted and ready to land.Aug 8 2022, 15:49

Closed by commit rABC12677a9f321d: Fix a race in the net tests (authored by Fabien). · Explain WhyAug 8 2022, 15:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC12677a9f321d: Fix a race in the net tests.

Revision Contents
Changeset List

Path

Size

src/

test/

net_tests.cpp

10 lines

Diff 34607

View Options

Fix a race in the net testsClosedPublicActions