Once a block has been voted on and finalized, there is no point polling
its ancestors anymore.
Test is added to check the ancestors are removed from the polls, and
also that a block from a forked chain is still polled, so invalidating a
block manually is still possible if needed and won't interfere.
Details
Details
- Reviewers
sdulfari - Group Reviewers
Restricted Project - Commits
- rABCcc47d240176a: [avalanche] Don't poll blocks who are ancestors of a vote finalized block
ninja all check-all
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/avalanche/test/processor_tests.cpp | ||
---|---|---|
1703 ↗ | (On Diff #34632) | If the tenth block was finalized shouldn't there be 9 left to poll? |
1711 ↗ | (On Diff #34632) | This loop is confusing. The comment says ancestors but i starts at 11. Just make i the actual index. |
1768 ↗ | (On Diff #34632) | Nit since prior votes were unknown |
src/avalanche/test/processor_tests.cpp | ||
---|---|---|
1703 ↗ | (On Diff #34632) | yes it's the eleventh here |