[avalanche] Don't poll blocks who are ancestors of a vote finalized block
ClosedPublic
Actions

Authored by Fabien on Aug 12 2022, 12:09.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCcc47d240176a: [avalanche] Don't poll blocks who are ancestors of a vote finalized block

Summary

Once a block has been voted on and finalized, there is no point polling
its ancestors anymore.
Test is added to check the ancestors are removed from the polls, and
also that a block from a forked chain is still polled, so invalidating a
block manually is still possible if needed and won't interfere.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_limit_block_vote_depth

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19808
Build 39330: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39329: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 12 2022, 12:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 12 2022, 12:09

Fabien requested review of this revision.Aug 12 2022, 12:09

Harbormaster completed remote builds in B19808: Diff 34632.Aug 12 2022, 12:30

sdulfari requested changes to this revision.Aug 12 2022, 16:26

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

src/avalanche/test/processor_tests.cpp
1703	If the tenth block was finalized shouldn't there be 9 left to poll?
1711	This loop is confusing. The comment says ancestors but `i` starts at 11. Just make `i` the actual index.
1768	Nit since prior votes were unknown