Page MenuHomePhabricator

[Cashtab] Patch mnemonic input color OnBoarding.js
ClosedPublic

Authored by kieran709 on Aug 12 2022, 17:08.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCdcaa8b902c14: [Cashtab] Patch mnemonic input color OnBoarding.js
Summary

Related to T2603. Changed font color of mnemonic input description and lock icon in OnBoarding.js form.

Test Plan

cd web/cashtab && npm start
open localhost:3000 in a private browser
observe that the lock icon in the form input is now blue
observe that the explanation text 'Valid mnemonic seed phrase required' is now white.

cd extension
npm run extension
in browser, navigate to chrome extension
if there are saved wallets in extension's local storage, delete them
observe that the lock icon, and the text ''Valid mnemonic seed phrase required'' are the correct color (cashtabBlue and white respectively).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman added inline comments.
web/cashtab/src/components/OnBoarding/OnBoarding.js
19 ↗(On Diff #34644)

Will this not work if added in the GlobalStyle object in App.js ?

Preference is to put all of these antd class patches in the same place, so that it's easier to work through them later when we get around to deprecating antd.

If that implementation won't work for whatever reason -- ok to leave it here. Let me know.

Note: Remember to implement it for both the extension and the normal App.js

This revision now requires changes to proceed.Aug 15 2022, 22:46

Responding to review feedback.

This revision is now accepted and ready to land.Aug 16 2022, 22:46