Page MenuHomePhabricator

[avalanche] Improve the getavalancheinfo RPC
ClosedPublic

Authored by Fabien on Aug 15 2022, 15:42.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABC68f02a8950d6: [avalanche] Improve the getavalancheinfo RPC
Summary

This RPC has been provably confusing during the tests, so let's try to make it better:

  • Rename some fields:
    • active => ready_to_poll
    • live => verified
    • orphan_proof_count => immature_proof_count (needs to be updated in others places as well but out of scope)
  • Include ourself in the total proof, node and stake count. This means that the total is now given directly with no math involved, and all the nodes from the network will get the same values as an RPC output.
  • Improve the documentation to reflect these changes.
Test Plan
./test/functional/test_runner.py abc_rpc_getavalancheinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.Aug 15 2022, 15:42
Fabien planned changes to this revision.Aug 15 2022, 15:44

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_compactproofs.py ======

------- Stdout: -------
2022-08-15T15:49:01.870000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_20
2022-08-15T15:49:02.421000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:49:04.363000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:49:04.416000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:49:05.216000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:49:06.139000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:49:09.114000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:49:09.823000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:49:09.976000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:49:10.186000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:49:10.350000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:49:10.534000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:49:10.699000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:49:10.908000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:49:11.154000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:49:11.337000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:49:11.829000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:49:12.032000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:49:12.082000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:49:13.498000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:49:14.163000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:49:15.158000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:49:15.969000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:49:16.526000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:49:16.577000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:49:16.779000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_20
2022-08-15T15:49:16.779000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_20/test_framework.log
2022-08-15T15:49:16.779000Z TestFramework (ERROR): 
2022-08-15T15:49:16.780000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_20' to consolidate all logs
2022-08-15T15:49:16.780000Z TestFramework (ERROR): 
2022-08-15T15:49:16.780000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:49:16.780000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:49:16.780000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_compactproofs.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:49:03.962000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_22
2022-08-15T15:49:04.507000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:49:06.595000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:49:06.648000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:49:07.414000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:49:08.197000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:49:10.783000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:49:11.298000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:49:11.410000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:49:11.691000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:49:11.848000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:49:12.009000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:49:12.166000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:49:12.328000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:49:12.540000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:49:12.753000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:49:13.142000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:49:13.345000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:49:13.395000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:49:14.838000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:49:15.493000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:49:16.285000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:49:17.095000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:49:17.863000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:49:17.915000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:49:18.119000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_22
2022-08-15T15:49:18.119000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_22/test_framework.log
2022-08-15T15:49:18.119000Z TestFramework (ERROR): 
2022-08-15T15:49:18.119000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_compactproofs_22' to consolidate all logs
2022-08-15T15:49:18.119000Z TestFramework (ERROR): 
2022-08-15T15:49:18.120000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:49:18.120000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:49:18.120000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_getavaaddr.py ======

------- Stdout: -------
2022-08-15T15:48:36.236000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_8
2022-08-15T15:48:40.601000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:44.447000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:47.386000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:48:49.850000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:48:52.019000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:48:55.820000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:48:55.876000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:48:56.179000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_8
2022-08-15T15:48:56.179000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_8/test_framework.log
2022-08-15T15:48:56.179000Z TestFramework (ERROR): 
2022-08-15T15:48:56.179000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_8' to consolidate all logs
2022-08-15T15:48:56.179000Z TestFramework (ERROR): 
2022-08-15T15:48:56.179000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:48:56.179000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:48:56.180000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_getavaaddr.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:48:36.751000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_9
2022-08-15T15:48:40.661000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:44.447000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:47.543000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:48:52.014000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:48:52.749000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:48:56.710000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:48:56.761000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:48:58.869000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_9
2022-08-15T15:48:58.869000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_9/test_framework.log
2022-08-15T15:48:58.869000Z TestFramework (ERROR): 
2022-08-15T15:48:58.869000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220815_154801/abc_p2p_getavaaddr_9' to consolidate all logs
2022-08-15T15:48:58.869000Z TestFramework (ERROR): 
2022-08-15T15:48:58.869000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:48:58.869000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:48:58.869000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_compactproofs.py
Bitcoin ABC functional tests: abc_p2p_compactproofs.py --nolegacyavaproof
Bitcoin ABC functional tests: abc_p2p_getavaaddr.py
Bitcoin ABC functional tests: abc_p2p_getavaaddr.py --nolegacyavaproof

Update the other tests that used this RPC

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_compactproofs.py ======

------- Stdout: -------
2022-08-15T15:49:45.494000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_20
2022-08-15T15:49:46.572000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:49:48.762000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:49:48.815000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:49:49.616000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:49:49.987000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:49:54.171000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:49:54.942000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:49:55.097000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:49:55.370000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:49:55.538000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:49:55.719000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:49:55.890000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:49:56.073000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:49:56.255000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:49:56.490000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:49:57.326000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:49:57.533000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:49:57.583000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:49:59.029000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:49:59.690000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:50:01.299000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:50:02.460000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:50:03.166000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:50:03.217000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:50:03.469000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_20
2022-08-15T15:50:03.470000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_20/test_framework.log
2022-08-15T15:50:03.470000Z TestFramework (ERROR): 
2022-08-15T15:50:03.470000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_20' to consolidate all logs
2022-08-15T15:50:03.470000Z TestFramework (ERROR): 
2022-08-15T15:50:03.470000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:50:03.470000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:50:03.470000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_compactproofs.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:50:00.566000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_22
2022-08-15T15:50:01.491000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:50:03.508000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:50:03.559000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:50:04.340000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:50:05.128000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:50:09.359000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:50:10.130000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:50:10.284000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:50:10.547000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:50:10.708000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:50:10.876000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:50:11.038000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:50:11.209000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:50:11.384000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:50:11.656000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:50:12.486000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:50:12.689000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:50:12.739000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:50:14.168000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:50:14.880000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:50:16.323000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:50:17.333000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:50:18.190000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:50:18.241000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:50:18.543000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_22
2022-08-15T15:50:18.543000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_22/test_framework.log
2022-08-15T15:50:18.543000Z TestFramework (ERROR): 
2022-08-15T15:50:18.544000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_compactproofs_22' to consolidate all logs
2022-08-15T15:50:18.544000Z TestFramework (ERROR): 
2022-08-15T15:50:18.544000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:50:18.544000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:50:18.544000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_getavaaddr.py ======

------- Stdout: -------
2022-08-15T15:48:26.615000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_8
2022-08-15T15:48:32.178000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:32.179000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:32.179000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:32.180000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:32.180000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:38.469000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:38.470000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:38.470000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:38.472000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:38.472000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:38.473000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:38.473000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:43.575000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:48:46.412000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:48:47.193000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:48:51.487000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:48:51.548000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:48:51.699000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_8
2022-08-15T15:48:51.699000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_8/test_framework.log
2022-08-15T15:48:51.699000Z TestFramework (ERROR): 
2022-08-15T15:48:51.699000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_8' to consolidate all logs
2022-08-15T15:48:51.699000Z TestFramework (ERROR): 
2022-08-15T15:48:51.699000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:48:51.699000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:48:51.699000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_getavaaddr.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:48:50.536000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_9
2022-08-15T15:48:53.886000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:48:58.333000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:49:02.636000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:49:05.113000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:49:07.008000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:49:11.297000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:49:11.359000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:49:12.212000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_9
2022-08-15T15:49:12.212000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_9/test_framework.log
2022-08-15T15:49:12.212000Z TestFramework (ERROR): 
2022-08-15T15:49:12.213000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20220815_154728/abc_p2p_getavaaddr_9' to consolidate all logs
2022-08-15T15:49:12.213000Z TestFramework (ERROR): 
2022-08-15T15:49:12.213000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:49:12.213000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:49:12.213000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_compactproofs.py
Bitcoin ABC functional tests: abc_p2p_compactproofs.py --nolegacyavaproof
Bitcoin ABC functional tests: abc_p2p_getavaaddr.py
Bitcoin ABC functional tests: abc_p2p_getavaaddr.py --nolegacyavaproof

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_compactproofs.py ======

------- Stdout: -------
2022-08-15T15:50:50.524000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_20
2022-08-15T15:50:51.046000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:50:53.169000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:50:53.222000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:50:54.021000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:50:54.740000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:50:56.950000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:50:57.328000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:50:57.481000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:50:57.764000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:50:57.947000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:50:58.108000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:50:58.295000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:50:58.514000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:50:58.757000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:50:58.970000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:50:59.488000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:50:59.695000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:50:59.745000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:51:01.182000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:51:01.837000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:51:02.792000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:51:03.655000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:51:04.211000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:51:04.262000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:51:04.515000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_20
2022-08-15T15:51:04.515000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_20/test_framework.log
2022-08-15T15:51:04.515000Z TestFramework (ERROR): 
2022-08-15T15:51:04.515000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_20' to consolidate all logs
2022-08-15T15:51:04.515000Z TestFramework (ERROR): 
2022-08-15T15:51:04.515000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:51:04.515000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:51:04.515000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_compactproofs.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:51:03.231000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_22
2022-08-15T15:51:03.729000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:51:05.870000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:51:05.921000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:51:06.695000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:51:07.475000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:51:09.471000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:51:10.066000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:51:10.172000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:51:10.438000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:51:10.595000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:51:10.766000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:51:10.930000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:51:11.103000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:51:11.341000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:51:11.560000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:51:11.947000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:51:12.151000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:51:12.202000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:51:13.628000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:51:14.283000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:51:15.176000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:51:16.035000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:51:16.390000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:51:16.440000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:51:16.693000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_22
2022-08-15T15:51:16.693000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_22/test_framework.log
2022-08-15T15:51:16.693000Z TestFramework (ERROR): 
2022-08-15T15:51:16.693000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_compactproofs_22' to consolidate all logs
2022-08-15T15:51:16.693000Z TestFramework (ERROR): 
2022-08-15T15:51:16.693000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:51:16.693000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:51:16.693000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_getavaaddr.py ======

------- Stdout: -------
2022-08-15T15:49:57.184000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_8
2022-08-15T15:50:07.757000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:07.757000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:07.757000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:07.757000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:07.757000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:07.757000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.110000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.110000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.111000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.111000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.111000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.112000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.112000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:14.112000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:18.478000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:50:20.907000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:50:22.530000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:50:26.318000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:50:26.369000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:50:26.571000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_8
2022-08-15T15:50:26.572000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_8/test_framework.log
2022-08-15T15:50:26.572000Z TestFramework (ERROR): 
2022-08-15T15:50:26.573000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_8' to consolidate all logs
2022-08-15T15:50:26.573000Z TestFramework (ERROR): 
2022-08-15T15:50:26.573000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:50:26.573000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:50:26.574000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: abc_p2p_getavaaddr.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:50:06.852000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_9
2022-08-15T15:50:12.037000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:12.037000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:12.037000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:12.038000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:12.038000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:12.038000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:17.368000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:17.369000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:17.369000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:17.369000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:17.369000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:17.370000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:50:20.767000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:50:23.233000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:50:23.644000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:50:27.591000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:50:27.642000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:50:27.968000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_9
2022-08-15T15:50:27.968000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_9/test_framework.log
2022-08-15T15:50:27.968000Z TestFramework (ERROR): 
2022-08-15T15:50:27.969000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_154920/abc_p2p_getavaaddr_9' to consolidate all logs
2022-08-15T15:50:27.969000Z TestFramework (ERROR): 
2022-08-15T15:50:27.969000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:50:27.970000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:50:27.970000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_compactproofs.py ======

------- Stdout: -------
2022-08-15T15:55:26.772000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_20
2022-08-15T15:55:27.674000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:55:29.795000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:55:29.846000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:55:30.662000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:55:31.027000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:55:33.162000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:55:33.774000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:55:33.881000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:55:34.102000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:55:34.271000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:55:34.466000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:55:34.651000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:55:34.831000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:55:35.043000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:55:35.225000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:55:35.610000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:55:35.812000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:55:35.862000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:55:37.285000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:55:37.943000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:55:38.851000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:55:39.936000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:55:40.497000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:55:40.548000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:55:40.801000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_20
2022-08-15T15:55:40.802000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_20/test_framework.log
2022-08-15T15:55:40.802000Z TestFramework (ERROR): 
2022-08-15T15:55:40.802000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_20' to consolidate all logs
2022-08-15T15:55:40.802000Z TestFramework (ERROR): 
2022-08-15T15:55:40.802000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:55:40.803000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:55:40.803000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_compactproofs.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:55:39.611000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_22
2022-08-15T15:55:40.435000Z TestFramework (INFO): Check we send a getavaproofs message to our avalanche outbound peers
2022-08-15T15:55:42.560000Z TestFramework (INFO): Check we send periodic getavaproofs message to some of our peers
2022-08-15T15:55:42.611000Z TestFramework (INFO): After the first avaproofs has been received, all the peers are requested periodically
2022-08-15T15:55:43.385000Z TestFramework (INFO): Check we send a getavaproofs message to our manually connected peers that support avalanche
2022-08-15T15:55:43.871000Z TestFramework (INFO): Check the node responds to getavaproofs messages
2022-08-15T15:55:46.414000Z TestFramework (INFO): Check the node requests the missing proofs after receiving an avaproofs message
2022-08-15T15:55:46.792000Z TestFramework (INFO): The node ignores unsollicited avaproofs
2022-08-15T15:55:46.945000Z TestFramework (INFO): Check no proof is requested if there is no shortid
2022-08-15T15:55:47.203000Z TestFramework (INFO): Check the node requests all the proofs if it known none
2022-08-15T15:55:47.359000Z TestFramework (INFO): Check the node requests only the missing proofs
2022-08-15T15:55:47.520000Z TestFramework (INFO): Check the node don't request prefilled proofs
2022-08-15T15:55:47.678000Z TestFramework (INFO): Check the node requests no proof if it knows all of them
2022-08-15T15:55:47.839000Z TestFramework (INFO): Check out of bounds index
2022-08-15T15:55:48.052000Z TestFramework (INFO): An invalid prefilled proof will trigger a ban
2022-08-15T15:55:48.266000Z TestFramework (INFO): Check the node respond to missing proofs requests
2022-08-15T15:55:48.651000Z TestFramework (INFO): Unsollicited requests are ignored
2022-08-15T15:55:48.853000Z TestFramework (INFO): Sending an empty request has no effect
2022-08-15T15:55:48.903000Z TestFramework (INFO): Check the requested proofs are sent by the node
2022-08-15T15:55:50.326000Z TestFramework (INFO): Check the node will not send the proofs if not requested before the timeout elapsed
2022-08-15T15:55:50.981000Z TestFramework (INFO): Check the node get compact proofs upon avalanche outbound discovery
2022-08-15T15:55:51.875000Z TestFramework (INFO): Check the node don't request compact proofs during IBD
2022-08-15T15:55:52.682000Z TestFramework (INFO): Check we also request the inbounds until the quorum is established
2022-08-15T15:55:53.238000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 676, in run_test
    self.test_send_inbound_getavaproofs_until_quorum_is_established()
  File "/work/test/functional/abc_p2p_compactproofs.py", line 623, in test_send_inbound_getavaproofs_until_quorum_is_established
    assert_equal(node.getavalancheinfo()['active'], False)
KeyError: 'active'
2022-08-15T15:55:53.288000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:55:53.491000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_22
2022-08-15T15:55:53.491000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_22/test_framework.log
2022-08-15T15:55:53.491000Z TestFramework (ERROR): 
2022-08-15T15:55:53.491000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_compactproofs_22' to consolidate all logs
2022-08-15T15:55:53.491000Z TestFramework (ERROR): 
2022-08-15T15:55:53.491000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:55:53.491000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:55:53.492000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py ======

------- Stdout: -------
2022-08-15T15:54:36.972000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_8
2022-08-15T15:54:39.479000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:54:43.250000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20512 due to [Errno 104] Connection reset by peer
2022-08-15T15:54:46.217000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:54:48.598000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:54:49.621000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:54:53.665000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:54:53.721000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:54:53.923000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_8
2022-08-15T15:54:53.923000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_8/test_framework.log
2022-08-15T15:54:53.923000Z TestFramework (ERROR): 
2022-08-15T15:54:53.924000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_8' to consolidate all logs
2022-08-15T15:54:53.924000Z TestFramework (ERROR): 
2022-08-15T15:54:53.924000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:54:53.924000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:54:53.924000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py --nolegacyavaproof ======

------- Stdout: -------
2022-08-15T15:54:37.335000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_9
2022-08-15T15:54:39.836000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:54:43.460000Z TestFramework.p2p (WARNING): Connection lost to 127.0.0.1:20576 due to [Errno 104] Connection reset by peer
2022-08-15T15:54:46.855000Z TestFramework (INFO): Check we send a getavaaddr message to our avalanche outbound peers
2022-08-15T15:54:49.298000Z TestFramework (INFO): Check we send a getavaaddr message to our manually connected peers that support avalanche
2022-08-15T15:54:49.840000Z TestFramework (INFO): Check we send a getavaaddr message while our quorum is not established
2022-08-15T15:54:54.003000Z TestFramework (ERROR): Key error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 465, in run_test
    self.getavaaddr_noquorum()
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in getavaaddr_noquorum
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
  File "/work/test/functional/test_framework/test_framework.py", line 677, in wait_until
    timeout_factor=self.options.timeout_factor)
  File "/work/test/functional/test_framework/util.py", line 271, in wait_until_helper
    if predicate():
  File "/work/test/functional/abc_p2p_getavaaddr.py", line 374, in <lambda>
    self.wait_until(lambda: node.getavalancheinfo()['active'] is True)
KeyError: 'active'
2022-08-15T15:54:54.054000Z TestFramework (INFO): Stopping nodes
2022-08-15T15:54:54.356000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_9
2022-08-15T15:54:54.357000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_9/test_framework.log
2022-08-15T15:54:54.357000Z TestFramework (ERROR): 
2022-08-15T15:54:54.357000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220815_155355/abc_p2p_getavaaddr_9' to consolidate all logs
2022-08-15T15:54:54.357000Z TestFramework (ERROR): 
2022-08-15T15:54:54.358000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-08-15T15:54:54.358000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-08-15T15:54:54.358000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_compactproofs.py
Bitcoin ABC functional tests: abc_p2p_compactproofs.py --nolegacyavaproof
Bitcoin ABC functional tests: abc_p2p_getavaaddr.py
Bitcoin ABC functional tests: abc_p2p_getavaaddr.py --nolegacyavaproof
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_compactproofs.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_compactproofs.py --nolegacyavaproof
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_getavaaddr.py --nolegacyavaproof

Improve the "verified" flag doc and add the missing dangling proof doc

is_polling => ready_to_poll

This revision is now accepted and ready to land.Aug 15 2022, 20:45
This revision was automatically updated to reflect the committed changes.