Differential D11866

[avalanche] Complete renaming from orphan to immature where applicable
ClosedPublic
Actions

Authored by Fabien on Aug 17 2022, 10:16.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABCa3951559f443: [avalanche] Complete renaming from orphan to immature where applicable

Summary

This rename the remaining variables and comments where this is relevant, so the code and comments are in par with the behavior.

Depends on D11864.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_more_orphan_rename

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19837
Build 39388: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 39387: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 17 2022, 10:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2022, 10:16

Fabien requested review of this revision.Aug 17 2022, 10:16

Harbormaster completed remote builds in B19837: Diff 34680.Aug 17 2022, 10:53

sdulfari accepted this revision.Aug 17 2022, 16:00

sdulfari added a subscriber: sdulfari.

sdulfari added inline comments.

test/functional/abc_p2p_avalanche_proof_voting.py
120	Nit

This revision is now accepted and ready to land.Aug 17 2022, 16:00

Closed by commit rABCa3951559f443: [avalanche] Complete renaming from orphan to immature where applicable (authored by Fabien). · Explain WhyAug 17 2022, 16:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa3951559f443: [avalanche] Complete renaming from orphan to immature where applicable.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

6 lines

processor.cpp

2 lines

test/

peermanager_tests.cpp

101 lines

processor_tests.cpp

26 lines

test/

functional/

abc_p2p_avalanche_proof_voting.py

20 lines

abc_p2p_proof_inventory.py

11 lines

abc_rpc_avalancheproof.py

9 lines

abc_rpc_getavalancheinfo.py

8 lines

p2p_inv_download.py

14 lines

test_framework/

messages.py

2 lines

Diff 34680

View Options

src/avalanche/peermanager.cpp

View Options

src/avalanche/processor.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

View Options

test/functional/abc_p2p_proof_inventory.py

View Options

test/functional/abc_rpc_avalancheproof.py

View Options

test/functional/abc_rpc_getavalancheinfo.py

View Options

test/functional/p2p_inv_download.py

View Options

test/functional/test_framework/messages.py

[avalanche] Complete renaming from orphan to immature where applicableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34680

src/avalanche/peermanager.cpp

src/avalanche/processor.cpp

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/processor_tests.cpp

test/functional/abc_p2p_avalanche_proof_voting.py

test/functional/abc_p2p_proof_inventory.py

test/functional/abc_rpc_avalancheproof.py

test/functional/abc_rpc_getavalancheinfo.py

test/functional/p2p_inv_download.py

test/functional/test_framework/messages.py

[avalanche] Complete renaming from orphan to immature where applicable
ClosedPublic
Actions

Revision Contents
Changeset List