Differential D11870

[avalanche] Fix flakiness where finalization of the newly mature proof was not checked along with the other finalized proofs
ClosedPublic
Actions

Authored by sdulfari on Aug 17 2022, 19:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC488982b50207: [avalanche] Fix flakiness where finalization of the newly mature proof was not…

Summary

The immature proof is not accounted for in the finalization checks at the end of the test. This makes the finalized_proof_count flaky since all proofs are being voted for.

This patch ensures the immature proof is also finalized.

Test Plan

ninja
./test/functional/test_runner.py abc_rpc_getavalancheinfo

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Aug 17 2022, 19:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2022, 19:01

sdulfari requested review of this revision.Aug 17 2022, 19:01

Harbormaster completed remote builds in B19844: Diff 34695.Aug 17 2022, 19:19

Fabien accepted this revision.Aug 17 2022, 20:01

This revision is now accepted and ready to land.Aug 17 2022, 20:01

Closed by commit rABC488982b50207: [avalanche] Fix flakiness where finalization of the newly mature proof was not… (authored by sdulfari). · Explain WhyAug 17 2022, 20:29

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC488982b50207: [avalanche] Fix flakiness where finalization of the newly mature proof was not….

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_rpc_getavalancheinfo.py

4 lines

Diff 34696

View Options

test/functional/abc_rpc_getavalancheinfo.py

[avalanche] Fix flakiness where finalization of the newly mature proof was not checked along with the other finalized proofsClosedPublicActions