Differential D11873

[avalanche] Implement proof expiration time
ClosedPublic
Actions

Authored by Fabien on Aug 18 2022, 14:55.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC26d8645919e9: [avalanche] Implement proof expiration time

Summary

A proof with a negative or zero expiration time will never expire, any other value will expire once the tip MTP is greater or equal to the expiration time.

Test Plan

ninja all check-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_proof_expiration_time

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19861
Build 39436: Build Diff	lint-circular-dependencies · build-diff · build-clang-tidy · build-without-wallet · build-clang · build-debug
Build 39435: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 18 2022, 14:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 18 2022, 14:55

Fabien requested review of this revision.Aug 18 2022, 14:55

Harbormaster completed remote builds in B19852: Diff 34705.Aug 18 2022, 15:09

At a minimum, needs these test cases and maybe more:

Start a node and expire its proof.
Start a node and expire its proof with conflict replacement.
Check quorum status when expiration occurs.

This revision now requires changes to proceed.Aug 18 2022, 18:08

Add the requested test cases

Harbormaster completed remote builds in B19861: Diff 34717.Aug 19 2022, 13:41

sdulfari accepted this revision.Aug 19 2022, 16:20

This revision is now accepted and ready to land.Aug 19 2022, 16:20

Closed by commit rABC26d8645919e9: [avalanche] Implement proof expiration time (authored by Fabien). · Explain WhyAug 19 2022, 16:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC26d8645919e9: [avalanche] Implement proof expiration time.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

7 lines

test/

peermanager_tests.cpp

46 lines

processor_tests.cpp

31 lines

proof_tests.cpp

30 lines

1 line

test/

functional/

abc_p2p_avalanche_peer_discovery.py

2 lines

abc_p2p_avalanche_proof_voting.py

2 lines

abc_p2p_avalanche_voting.py

2 lines

abc_rpc_avalancheproof.py

7 lines

abc_rpc_getavalancheinfo.py

2 lines

abc_rpc_getavalanchepeerinfo.py

2 lines

Diff 34717

src/avalanche/proof.cpp

Loading...

src/avalanche/test/peermanager_tests.cpp

Loading...

src/avalanche/test/processor_tests.cpp

Loading...

src/avalanche/test/proof_tests.cpp

Loading...

src/avalanche/validation.h

Loading...

test/functional/abc_p2p_avalanche_peer_discovery.py

Loading...

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...

test/functional/abc_p2p_avalanche_voting.py

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...

test/functional/abc_rpc_getavalancheinfo.py

Loading...

test/functional/abc_rpc_getavalanchepeerinfo.py

Loading...