Differential D11880

[avalanche] Add log message when dangling proofs get dropped
ClosedPublic
Actions

Authored by sdulfari on Aug 22 2022, 22:41.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4bb701324f80: [avalanche] Add log message when dangling proofs get dropped

Summary

Currently, logs for dangling-proof only appear when a proof is rejected for having already been dropped.
This is confusing because the initial dropping is not logged and may have occurred much earlier.

Test Plan

ninja check bitcoind bitcoin-cli
./test/functional/test_runner.py abc_feature_proof_cleanup

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.Aug 22 2022, 22:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 22 2022, 22:41

sdulfari requested review of this revision.Aug 22 2022, 22:41

Harbormaster completed remote builds in B19867: Diff 34724.Aug 22 2022, 22:59

Fabien accepted this revision.Aug 24 2022, 21:16

Fabien added a subscriber: Fabien.

Fabien added inline comments.

test/functional/abc_feature_proof_cleanup.py
100 ↗	(On Diff #34724)	Nit: you can use uint256_hex()

This revision is now accepted and ready to land.Aug 24 2022, 21:16

Closed by commit rABC4bb701324f80: [avalanche] Add log message when dangling proofs get dropped (authored by sdulfari). · Explain WhyAug 26 2022, 16:14

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABC4bb701324f80: [avalanche] Add log message when dangling proofs get dropped.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

4 lines

test/

functional/

abc_feature_proof_cleanup.py

7 lines

Diff 34742

View Options

src/avalanche/peermanager.cpp