Differential D11882

Center loading icon
ClosedPublic
Actions

Authored by johnkuney on Aug 24 2022, 14:22.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCd923fe4722bc: Center loading icon

Summary

Centering the antd loading icon. Added two overridding css items in the app.js component in order to adjust the antd styling

Test Plan

run the app and see if the loading icon looks more centered. Could force it to always be on to see more closely

Diff Detail

Repository

rABC Bitcoin ABC

Branch

center-loading-icon

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19873
Build 39460: Build Diff	cashtab-tests
Build 39459: arc lint + arc unit

Event Timeline

johnkuney created this revision.Aug 24 2022, 14:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2022, 14:22

johnkuney requested review of this revision.Aug 24 2022, 14:22

Harbormaster completed remote builds in B19873: Diff 34734.Aug 24 2022, 14:25

Add the same change in extension/src/components/App.js

This revision now requires changes to proceed.Aug 25 2022, 21:56

Centering loading icon for web and extension

Harbormaster completed remote builds in B19880: Diff 34745.Aug 26 2022, 21:21

bytesofman accepted this revision.Aug 27 2022, 01:21

This revision is now accepted and ready to land.Aug 27 2022, 01:21

Closed by commit rABCd923fe4722bc: Center loading icon (authored by johnkuney). · Explain WhyAug 29 2022, 23:39

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABCd923fe4722bc: Center loading icon.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

App.js

10 lines

Diff 34734

View Options

web/cashtab/src/components/App.js

Center loading iconClosedPublicActions