Page MenuHomePhabricator
Differential D11890

[Cashtab] Refresh fiat price on wallet open
AbandonedPublic
Actions

Authored by emack on Aug 29 2022, 04:55.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

As per observation in T2629, this diff refreshes the selected fiat price upon wallet open.

Test Plan

npm test
send a fiat denominated XEC tx and validate exchange rate matches CoinGecko

Diff Detail

Repository
rABC Bitcoin ABC
Branch
updateFiatPriceOnStartup
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19890
Build 39487: Build Diffcashtab-tests
Build 39486: arc lint + arc unit

Event Timeline

emack created this revision.Aug 29 2022, 04:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 29 2022, 04:55
emack requested review of this revision.Aug 29 2022, 04:55
Harbormaster completed remote builds in B19890: Diff 34756.Aug 29 2022, 04:58
bytesofman requested changes to this revision.Aug 29 2022, 18:16
bytesofman added inline comments.
web/cashtab/src/hooks/useWallet.js
1436

This is already being done in initializeFiatPriceApi(initialSettings.fiatCurrency) above

So, if users are starting up the wallet and not seeing an update, there is some other issue going on. Is the function failing to fire?

Need to do some testing with console.log statements and see what's going on.

This revision now requires changes to proceed.Aug 29 2022, 18:16
bytesofman added a comment.Sep 20 2022, 18:27

Please abandon if no action

emack abandoned this revision.Sep 21 2022, 00:27

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
hooks/
1 line

Diff 34756

View Options

web/cashtab/src/hooks/useWallet.js

Loading...