Differential D11903

[avalanche] Fix a race in the processor tests
ClosedPublic
Actions

Authored by Fabien on Sep 1 2022, 09:27.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCa0ffea9a1129: [avalanche] Fix a race in the processor tests

Summary

The quorum detection test creates a new processor but doesn't delete the one from the fixture, causing double registration/deletion upon updated block tip and causing a potential use-after-free issue.

Test Plan

Run the test with ASAN 100 times in a loop.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 1 2022, 09:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2022, 09:27

Fabien requested review of this revision.Sep 1 2022, 09:27

@bot build-asan

teamcity awarded a token.Sep 1 2022, 09:29

Harbormaster completed remote builds in B19911: Diff 34787.Sep 1 2022, 09:44

PiRK accepted this revision.Sep 2 2022, 06:20

This revision is now accepted and ready to land.Sep 2 2022, 06:20

Closed by commit rABCa0ffea9a1129: [avalanche] Fix a race in the processor tests (authored by Fabien). · Explain WhySep 2 2022, 08:08

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa0ffea9a1129: [avalanche] Fix a race in the processor tests.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

81 lines

Diff 34801

View Options

src/avalanche/test/processor_tests.cpp

[avalanche] Fix a race in the processor testsClosedPublicActions