[Cashtab] Use correct type for comparison to dustSats
ClosedPublic
Actions

Authored by bytesofman on Sep 7 2022, 05:11.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC9ee42a28aa44: [Cashtab] Use correct type for comparison to dustSats

Summary

currency.dustSats is a number, 550

remainder is a BigNumber

Both should be a BigNumber to use the gte comparison

Test Plan

npm start, send etoken txs, confirm you get a change output unless change would be dust

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Sep 7 2022, 05:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 7 2022, 05:11

bytesofman requested review of this revision.Sep 7 2022, 05:11

Harbormaster completed remote builds in B19946: Diff 34840.Sep 7 2022, 05:13

emack accepted this revision.Sep 7 2022, 05:37

This revision is now accepted and ready to land.Sep 7 2022, 05:37

Closed by commit rABC9ee42a28aa44: [Cashtab] Use correct type for comparison to dustSats (authored by bytesofman). · Explain WhySep 7 2022, 05:39

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC9ee42a28aa44: [Cashtab] Use correct type for comparison to dustSats.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

hooks/

useBCH.js

2 lines

Diff 34841

View Options

web/cashtab/src/hooks/useBCH.js

[Cashtab] Use correct type for comparison to dustSatsClosedPublicActions