Differential D11945

[avalanche] Fix potential wrong error message in the sendavalancheproof RPC
ClosedPublic
Actions

Authored by Fabien on Sep 9 2022, 08:56.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe168baa665b5: [avalanche] Fix potential wrong error message in the sendavalancheproof RPC

Summary

The RPC does a lot of checks before attempting to register a proof and assumes it can only fail due to conflicts. This is no longer true since previously evicted dangling proofs are rejected.
This diff makes the error message more generic so the correct error message is returned, and new errors will be printed correctly as well.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 9 2022, 08:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2022, 08:56

Fabien requested review of this revision.Sep 9 2022, 08:56

Harbormaster completed remote builds in B19972: Diff 34884.Sep 9 2022, 09:16

PiRK accepted this revision.Sep 9 2022, 11:11

This revision is now accepted and ready to land.Sep 9 2022, 11:11

Closed by commit rABCe168baa665b5: [avalanche] Fix potential wrong error message in the sendavalancheproof RPC (authored by Fabien). · Explain WhySep 9 2022, 13:33

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCe168baa665b5: [avalanche] Fix potential wrong error message in the sendavalancheproof RPC.

Revision Contents
Changeset List

Path

Size

src/

rpc/

20 lines

test/

functional/

abc_feature_proof_cleanup.py

8 lines

abc_p2p_avalanche_proof_voting.py

3 lines

abc_rpc_avalancheproof.py

2 lines

Diff 34893

src/rpc/avalanche.cpp

Loading...

test/functional/abc_feature_proof_cleanup.py

Loading...

test/functional/abc_p2p_avalanche_proof_voting.py

Loading...

test/functional/abc_rpc_avalancheproof.py

Loading...