Differential D11961

[avalanche] Make a low dust threshold the default for functional tests
AbandonedPublic
Actions

Authored by sdulfari on Sep 12 2022, 16:49.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

A low dust threshold simplifies the tests by not requiring coinbase UTXOs to be combined to exceed the dust threshold.
We use this same dust threshold throughout the avalanche tests, so making it a default makes sense.

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

tests-default-dust

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19998
Build 39687: Build Diff	build-debug · build-diff · build-without-wallet · build-clang · build-clang-tidy
Build 39686: arc lint + arc unit

Event Timeline

sdulfari created this revision.Sep 12 2022, 16:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2022, 16:49

sdulfari requested review of this revision.Sep 12 2022, 16:49

Harbormaster completed remote builds in B19998: Diff 34927.Sep 12 2022, 17:04

I don't think it's a good idea to have a default test parameter that differs from the node default. It's just hiding the fact that the tests use a different value for whatever reason.

This revision now requires changes to proceed.Sep 12 2022, 18:11

sdulfari abandoned this revision.Jan 6 2023, 00:14