Page MenuHomePhabricator

[avalanche] Rename proof filter to match rest of the code base
ClosedPublic

Authored by sdulfari on Sep 12 2022, 20:21.

Details

Summary

rejectedProofs is confusing because these proofs are strictly only invalid due to consensus or invalidated by avalanche.
The avalanche module uses "invalidated" to mean proofs that were finalized in the rejected state. This patch makes the naming consistent.

Test Plan
ninja check check-functional

Diff Detail

Event Timeline

Fabien requested changes to this revision.Sep 13 2022, 07:42
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/net_processing.cpp
7125 ↗(On Diff #34931)

This is not the result of a vote, but just a plain consensus-invalid proof sent over the network.
This is making the name and description inaccurate.

This revision now requires changes to proceed.Sep 13 2022, 07:42

Make the naming more accurate for consensus-invalid case and update comment.

Please update the summary accordingly

This revision is now accepted and ready to land.Sep 13 2022, 18:11