Differential D11963

[avalanche] Rename proof filter to match rest of the code base
ClosedPublic
Actions

Authored by sdulfari on Sep 12 2022, 20:21.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6bd0f29f4332: [avalanche] Rename proof filter to match rest of the code base

Summary

rejectedProofs is confusing because these proofs are strictly only invalid due to consensus or invalidated by avalanche.
The avalanche module uses "invalidated" to mean proofs that were finalized in the rejected state. This patch makes the naming consistent.

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

inv-proof-filter-rename

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20022
Build 39733: Build Diff	build-without-wallet · build-diff · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug
Build 39732: arc lint + arc unit

Event Timeline

sdulfari created this revision.Sep 12 2022, 20:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 12 2022, 20:21

sdulfari requested review of this revision.Sep 12 2022, 20:21

Harbormaster completed remote builds in B20001: Diff 34931.Sep 12 2022, 20:38

Fabien requested changes to this revision.Sep 13 2022, 07:42

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net_processing.cpp
7125 ↗	(On Diff #34931)	This is not the result of a vote, but just a plain consensus-invalid proof sent over the network. This is making the name and description inaccurate.