[avalanche] Create a type alias for proof id sets
ClosedPublic
Actions

Authored by sdulfari on Sep 20 2022, 20:56.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

Summary

Passing around sets of proof ids is becoming more common with changes like D12013. Providing a type alias
for this just makes sense.

Test Plan

ninja check

Repository

rABC Bitcoin ABC

Branch

proof-id-set

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20131
Build 39949: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 39948: arc lint + arc unit

sdulfari requested review of this revision.Sep 20 2022, 20:56

Fabien requested changes to this revision.Sep 21 2022, 07:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/proofpool.cpp
9 ↗	(On Diff #35056)	IMO this indicates that ProofIdSet belongs to proofpool.h and not ProofId.h

This revision now requires changes to proceed.Sep 21 2022, 07:49

sdulfari requested review of this revision.Sep 21 2022, 16:13

sdulfari added inline comments.

src/avalanche/proofpool.cpp
9 ↗	(On Diff #35056)	If you want a ProofIdSet for some other purpose than using a pool, then why would you pull in proofpool.h? ProofPool is currently the primary usage but this is not guaranteed so I don't see a compelling reason to put it there.

src/avalanche/proofpool.cpp
9 ↗	(On Diff #35056)	For 2 reasons: There is currently no other use case in the current state of this diff, and I doubt there are many more waiting as the only module responsible of dealing with proofs is the peer manager The proofid module should not declare a type of a container of itself, when this is obvious that it will never be used in this compilation unit but only at the call sites.