Page MenuHomePhabricator

[avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr
ClosedPublic

Authored by sdulfari on Sep 20 2022, 23:47.

Details

Summary

The current delay isn't large enough. The chance that the next addr send time is longer than 300s
is roughly 1 in 22,000. We run abc_p2p_getavaaddr between 200 and 500 times per week and
wait_until(requester.addr_received) is called 4 times per test run which gives 800 to 2000 calls
per week. So even at the lower end of activity, we can expect to hit this at least once per month.

This patch increases the mock time step to actually be very unlikely, at roughly 1 in 485,000,000.

Test Plan
./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bump-test-addr-delay
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20092
Build 39871: Build Diffbuild-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 39870: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 21 2022, 07:50
sdulfari retitled this revision from [avalanche] Increase mock time delay for ava addr responses to [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr.Sep 21 2022, 16:10