Differential D12027

Fix an occasional failure in abc_p2p_fullblocktest
ClosedPublic
Actions

Authored by Fabien on Sep 21 2022, 17:13.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC248963c07738: Fix an occasional failure in abc_p2p_fullblocktest

Summary

The last action of the test is to submit a lare block by RPC. The node will attempt to relay that block to its peers which can cause a shutdown timeout on slow machines. Disconnecting the peers before calling the RPC should fix it.

Test Plan

./test/functional/test_runner.py abc_p2p_fullblocktest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 21 2022, 17:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2022, 17:13

Fabien requested review of this revision.Sep 21 2022, 17:13

Harbormaster completed remote builds in B20111: Diff 35090.Sep 21 2022, 18:02

sdulfari accepted this revision.Sep 21 2022, 18:44

This revision is now accepted and ready to land.Sep 21 2022, 18:44

Closed by commit rABC248963c07738: Fix an occasional failure in abc_p2p_fullblocktest (authored by Fabien). · Explain WhySep 21 2022, 18:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC248963c07738: Fix an occasional failure in abc_p2p_fullblocktest.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_fullblocktest.py

4 lines

Diff 35093

View Options

test/functional/abc_p2p_fullblocktest.py

Fix an occasional failure in abc_p2p_fullblocktestClosedPublicActions