HomePhabricator

[avalanche] Fix abc_p2p_compactproofs flakiness

Description

[avalanche] Fix abc_p2p_compactproofs flakiness

Summary:
The loop waiting for the message count to increase is not reliable because the lock has to be released between the calls, so a message can sneak in between and cause a timeout on the next iteration.

This diff updates the test to use a more simple and robust approach.

Test Plan:

./test/functional/test_runner.py abc_p2p_compactproofs

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12024

Details

Provenance
FabienAuthored on Sep 21 2022, 15:57
FabienPushed on Sep 21 2022, 16:52
Reviewer
Restricted Project
Differential Revision
D12024: [avalanche] Fix abc_p2p_compactproofs flakiness
Parents
rABC89e1f6634387: [avalanche] Increase mock time delay for addr responses in abc_p2p_getavaaddr
Branches
Unknown
Tags
Unknown