Page MenuHomePhabricator
Differential D12076

test: Fix intermittent issue in p2p_feefilter
ClosedPublic
Actions

Authored by PiRK on Sep 27 2022, 15:24.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCca33e0ea0971: test: Fix intermittent issue in p2p_feefilter
Summary

and fix typo (one tx is enough)

This is a backport of core#20176

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 27 2022, 15:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2022, 15:24
PiRK requested review of this revision.Sep 27 2022, 15:24
teamcity edited the summary of this revision. (Show Details)Sep 27 2022, 15:24
PiRK edited the summary of this revision. (Show Details)Sep 27 2022, 15:25
Harbormaster completed remote builds in B20205: Diff 35221.Sep 27 2022, 15:41
teamcity added a comment.Sep 27 2022, 15:41
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_feature_proof_cleanup.py ======

------- Stdout: -------
2022-09-27T15:34:55.698000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220927_153115/abc_feature_proof_cleanup_101
2022-09-27T15:34:57.388000Z TestFramework (INFO): No proof is cleaned before the timeout expires
2022-09-27T15:34:57.390000Z TestFramework (INFO): Check the proofs with attached nodes are not cleaned
2022-09-27T15:34:59.495000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 132, in main
    self.run_test()
  File "/work/test/functional/abc_feature_proof_cleanup.py", line 106, in run_test
    [proof.proofid for proof in proofs[:6]]), timeout=5)
  File "/usr/lib/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 535, in assert_debug_log
    str(expected_msgs), print_log))
  File "/work/test/functional/test_framework/test_node.py", line 213, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Expected messages "['Proof dropped for dangling too long (no connected node): b0c9fb26e9ec8257c394c959e2c3cd49c3fa004b5713fda025487edf14117d67', 'Proof dropped for dangling too long (no connected node): d4005b73d82dfe7efc07efa88166d578db68f4dbf402895fe5e576baa1fbda75', 'Proof dropped for dangling too long (no connected node): 31a886a71e9c79193c119669ee08a4263abce87d94cbe52fc650982d121f733d', 'Proof dropped for dangling too long (no connected node): 100fd162f9b47b9e5baa7f2c56d8aa7b980e22699abd68a387c527732d6a5194', 'Proof dropped for dangling too long (no connected node): 061490dc2f9c2f253aa921e33b47b2c1e18eaddf54dc5fcbb0e3a249a4f8bac1']" does not partially match log:

 - 2022-09-27T15:34:57.470819Z (mocktime: 2022-09-27T15:49:56Z) [../../src/httpserver.cpp:252] [http_request_cb] Received a POST request for / from 127.0.0.1:36158
 - 2022-09-27T15:34:57.471038Z (mocktime: 2022-09-27T15:49:56Z) [../../src/rpc/request.cpp:183] [parse] ThreadRPCServer method=mockscheduler user=__cookie__
 - 2022-09-27T15:34:57.472752Z (mocktime: 2022-09-27T15:49:56Z) [../../src/httpserver.cpp:252] [http_request_cb] Received a POST request for / from 127.0.0.1:36158
 - 2022-09-27T15:34:57.472949Z (mocktime: 2022-09-27T15:49:56Z) [../../src/random.cpp:573] [SeedPeriodic] Feeding 24838 bytes of dynamic environment data into RNG
 - 2022-09-27T15:34:57.473097Z (mocktime: 2022-09-27T15:49:56Z) [../../src/rpc/request.cpp:183] [parse] ThreadRPCServer method=getavalanchepeerinfo user=__cookie__
 - 2022-09-27T15:34:57.484356Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1724] [operator()] Requesting more avalanche addresses from peer 4
 - 2022-09-27T15:34:57.484403Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaaddr (0 bytes) peer=4
 - 2022-09-27T15:34:57.484491Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1724] [operator()] Requesting more avalanche addresses from peer 3
 - 2022-09-27T15:34:57.484530Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaaddr (0 bytes) peer=3
 - 2022-09-27T15:34:57.484610Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1724] [operator()] Requesting more avalanche addresses from peer 2
 - 2022-09-27T15:34:57.484652Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaaddr (0 bytes) peer=2
 - 2022-09-27T15:34:57.484714Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1724] [operator()] Requesting more avalanche addresses from peer 0
 - 2022-09-27T15:34:57.484751Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaaddr (0 bytes) peer=0
 - 2022-09-27T15:34:57.484807Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1724] [operator()] Requesting more avalanche addresses from peer 1
 - 2022-09-27T15:34:57.484843Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaaddr (0 bytes) peer=1
 - 2022-09-27T15:34:57.484900Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1759] [operator()] Requesting compact proofs from peer 4
 - 2022-09-27T15:34:57.484936Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaproofs (0 bytes) peer=4
 - 2022-09-27T15:34:57.484991Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1759] [operator()] Requesting compact proofs from peer 3
 - 2022-09-27T15:34:57.485026Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaproofs (0 bytes) peer=3
 - 2022-09-27T15:34:57.485081Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net_processing.cpp:1759] [operator()] Requesting compact proofs from peer 2
 - 2022-09-27T15:34:57.485132Z (mocktime: 2022-09-27T15:49:56Z) [../../src/net.cpp:3662] [PushMessage] sending getavaproofs (0 bytes) peer=2


2022-09-27T15:34:59.546000Z TestFramework (INFO): Stopping nodes
2022-09-27T15:34:59.798000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220927_153115/abc_feature_proof_cleanup_101
2022-09-27T15:34:59.798000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220927_153115/abc_feature_proof_cleanup_101/test_framework.log
2022-09-27T15:34:59.798000Z TestFramework (ERROR): 
2022-09-27T15:34:59.798000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20220927_153115/abc_feature_proof_cleanup_101' to consolidate all logs
2022-09-27T15:34:59.798000Z TestFramework (ERROR): 
2022-09-27T15:34:59.798000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-09-27T15:34:59.798000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-09-27T15:34:59.798000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_feature_proof_cleanup.py

Fabien accepted this revision.Sep 27 2022, 15:52
This revision is now accepted and ready to land.Sep 27 2022, 15:52
This revision was landed with ongoing or failed builds.Sep 28 2022, 06:03
Closed by commit rABCca33e0ea0971: test: Fix intermittent issue in p2p_feefilter (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCca33e0ea0971: test: Fix intermittent issue in p2p_feefilter.

Revision Contents
Changeset List

PathSize
test/
functional/
5 lines

Diff 35234

View Options

test/functional/p2p_feefilter.py

Loading...